Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| shell = setup_shell() | ||
| res = shell.exec("grep -e 'regex[0-9]+' -r /workspace/docs") | ||
| assert "/workspace/docs/guide.txt:regex123" in res.stdout | ||
| assert "/workspace/docs/reference/spec.txt:prefix regex999 suffix" in res.stdout |
There was a problem hiding this comment.
Fix grep regex test to use extended syntax
The new test_grep_recursive_regex asserts that grep -e 'regex[0-9]+' -r /workspace/docs finds two matches, but GNU grep defaults to basic regular expressions where + is treated as a literal character. Without escaping + or passing -E, the command never matches regex123 or regex999, so res.stdout stays empty and the test always fails with exit code 1. Please either escape the plus (regex[0-9]\+) or run grep -E so the quantifier works and the test reflects the intended behavior.
Useful? React with 👍 / 👎.
|
Summary
Testing
|
Summary
grep -n,grep -i, and recursive regex searches to ensure the host fallback behaves as expectedTesting
Codex Task