Repository navigation
docs: add docs/guide, a navigable hierarchy for newcomers - #40
Merged
Merged
Conversation
O projeto tem duas fontes canônicas — docs/PGFATHOM.md e os specs em openspec/ — mas as duas são o registro de raciocínio do mantenedor, em português, e nenhuma foi escrita pra orientar quem nunca leu nenhuma das duas. O README cobre bem o usuário final; faltava o equivalente pra quem chega querendo entender o código antes de mexer nele. docs/guide/ é essa camada: sete seções numeradas (visão geral, arquitetura, funcionalidades e segurança, uso, posicionamento e métricas, contribuição), cada uma com um README de índice, em inglês — a convenção já escrita no CONTRIBUTING.md para tudo que é contribuidor-facing. Nenhuma página duplica o conteúdo canônico por completo; cada uma orienta e linka de volta pra seção correspondente de docs/PGFATHOM.md, do README ou dos specs, pra que as duas fontes nunca divirjam silenciosamente. README.md ganha uma linha na seção Contributing apontando pro guia.
There was a problem hiding this comment.
Pull request overview
Adds a newcomer-oriented, English-language documentation guide under docs/guide/ that provides a navigable hierarchy and pointers back to the project’s canonical design/spec sources, and links it from the root README so contributors can find it quickly.
Changes:
- Add
docs/guide/with section indexes and supporting pages covering overview, architecture, features/safety, usage, positioning/metrics, and contributing. - Cross-link guide pages back to
docs/PGFATHOM.md,openspec/specs/, and relevantREADME.mdsections to avoid duplicating canonical content. - Update
README.mdto point new contributors to the guide.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Adds a Contributing-section pointer to the new docs/guide/ entry point. |
| docs/guide/README.md | Introduces the guide’s purpose and table of contents. |
| docs/guide/01-overview/README.md | Overview section index and reading order. |
| docs/guide/01-overview/the-problem.md | Explains the motivating problem the tool addresses. |
| docs/guide/01-overview/what-it-does.md | Summarizes what pgfathom does and its outputs/verdicts. |
| docs/guide/02-architecture/README.md | Architecture section index for layers/model/algorithm. |
| docs/guide/02-architecture/layers.md | Documents the layer boundaries and tech stack. |
| docs/guide/02-architecture/data-model.md | Sketches the core internal model structs and concepts. |
| docs/guide/02-architecture/algorithm.md | Describes the 7-stage discovery pipeline at a high level. |
| docs/guide/03-features-and-safety/README.md | Features & safety section index. |
| docs/guide/03-features-and-safety/naming-profiles.md | Explains naming profiles and normalization design. |
| docs/guide/03-features-and-safety/safety-guarantees.md | Documents the non-negotiable safety guarantees and enforcement. |
| docs/guide/03-features-and-safety/known-pitfalls.md | Lists concrete failure modes/pitfalls and how they’re handled. |
| docs/guide/04-usage/README.md | Usage section index. |
| docs/guide/04-usage/cli-reference.md | Adds an install/flags/output reference page. |
| docs/guide/05-positioning-and-metrics/README.md | Positioning & metrics section index. |
| docs/guide/05-positioning-and-metrics/prior-art.md | Provides a map of the “prior art” argument with links to README. |
| docs/guide/05-positioning-and-metrics/measuring-correctness.md | Explains the benchmark metric framing and links to full numbers. |
| docs/guide/06-contributing/README.md | Provides a shortest-path contributor entry and PR evaluation rules. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project has two canonical sources — docs/PGFATHOM.md and the specs under openspec/ — but both are the maintainer's design record, written in Portuguese, and neither was written to orient someone who's read neither. The README covers the end user well; there was no equivalent for someone arriving to understand the code before touching it.
docs/guide/ is that layer: seven numbered sections (overview, architecture, features & safety, usage, positioning & metrics, contributing), each with a README.md index — the GitHub convention that auto-renders when browsing into a folder. In English, following the rule already written in CONTRIBUTING.md for anything contributor-facing.
No page fully duplicates canonical content — each one orients and links back to the corresponding section of docs/PGFATHOM.md, the README, or the specs, so the two sources never silently drift apart. All relative links were validated by script.
README.md gets one line in the Contributing section pointing to the guide.
What changes, and why
How it was verified
make fmt && make lint && make testmake test-integration(if it touches SQL, the catalog, or validation)Checks
openspec/, validating with--strict