Skip to content

[WRONG BRANCH] fix(service): fail closed on systemctl probe errors - #291

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-systemd-probe-timeout-classification
Draft

[WRONG BRANCH] fix(service): fail closed on systemctl probe errors#291
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-systemd-probe-timeout-classification

Conversation

@luvs01

@luvs01 luvs01 commented Aug 15, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Prevent timeouts and other spawn errors from being treated as an absent systemd service, which could incorrectly allow ownership to be considered owned (fail-open) instead of blocking (fail-closed).

Description

  • Propagate the underlying spawn error code from the probe runner by adding spawnErrorCode to the ProbeRunner result and classifying ETIMEDOUT or a signaled child as a timeout rather than an ordinary spawn failure.
  • Treat only ENOENT spawn failures as kind: "absent" for systemctl, and map other spawn failures (e.g. ETIMEDOUT, EACCES, unspecified) to unknown so ownership checks remain fail-closed when the manager cannot be safely probed.
  • Update the Docker-focused probe test to supply spawnErrorCode for the ENOENT case and add regression tests asserting that ETIMEDOUT and EACCES are not treated as absent.

Testing

  • Ran bun test tests/service-probe-docker.test.ts and the new/updated tests passed (3/3 focused assertions).
  • Ran bun run typecheck and bun run privacy:scan, both completed without errors for the scoped change.
  • Attempted a broader bun run test run to exercise the whole suite, but unrelated existing test failures/timeouts in other subsystems prevented a fully green full-suite run; the change was validated with focused tests as recommended.

Codex Task

@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 46 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d004980c-0625-4600-859c-73a011262784

📥 Commits

Reviewing files that changed from the base of the PR and between 161c09f and 2d21bdf.

📒 Files selected for processing (2)
  • src/service-manager-probe.ts
  • tests/service-probe-docker.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 15, 2026
@github-actions github-actions Bot changed the title fix(service): fail closed on systemctl probe errors [WRONG BRANCH] fix(service): fail closed on systemctl probe errors Aug 15, 2026
@github-actions

github-actions Bot commented Aug 15, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 15, 2026 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant