[WRONG BRANCH] fix(service): fail closed on systemctl probe errors - #291
[WRONG BRANCH] fix(service): fail closed on systemctl probe errors#291luvs01 wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 46 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
owned(fail-open) instead of blocking (fail-closed).Description
spawnerror code from the probe runner by addingspawnErrorCodeto theProbeRunnerresult and classifyingETIMEDOUTor a signaled child as a timeout rather than an ordinary spawn failure.ENOENTspawn failures askind: "absent"for systemctl, and map other spawn failures (e.g.ETIMEDOUT,EACCES, unspecified) tounknownso ownership checks remain fail-closed when the manager cannot be safely probed.spawnErrorCodefor the ENOENT case and add regression tests asserting thatETIMEDOUTandEACCESare not treated as absent.Testing
bun test tests/service-probe-docker.test.tsand the new/updated tests passed (3/3 focused assertions).bun run typecheckandbun run privacy:scan, both completed without errors for the scoped change.bun run testrun to exercise the whole suite, but unrelated existing test failures/timeouts in other subsystems prevented a fully green full-suite run; the change was validated with focused tests as recommended.Codex Task