[WRONG BRANCH] fix(antigravity): route partial Gemini 3.7 discovery tiers to tiered wire id - #289
[WRONG BRANCH] fix(antigravity): route partial Gemini 3.7 discovery tiers to tiered wire id#289luvs01 wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 58 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c3c9c2a8fd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (discoveryTier) { | ||
| return { wireModelId: GEMINI_FLASH_WIRE_ID, thinkingLevel: discoveryTier }; | ||
| } |
There was a problem hiding this comment.
Canonicalize partial tier IDs for usage pricing
When live discovery returns a partial Gemini 3.7 tier set and a user selects one of these suffix IDs, this branch makes the request succeed under gemini-3.7-flash-tiered, but the requested suffix remains absent from ANTIGRAVITY_USAGE_BASE_BY_ID. Usage and cost records retain the requested model, and resolveMatchedPrice only falls back to the base price when canonicalAntigravityUsageModel changes that ID, so successful gemini-3.7-flash-low/medium/high calls have no cost estimate despite the existing gemini-3.7-flash price. Map these newly routable IDs to the base model in the usage reverse map and cover the price lookup.
Useful? React with 👍 / 👎.
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
gemini-3.7-flash-low) were exposed as callable IDs but the runtime path sent them unchanged, which produces invalid upstream CCA requests because CCA expects the singlegemini-3.7-flash-tieredwire id plus athinkingLevel.thinkingLevelinstead of being treated as suffix/compat ids.Description
CURRENT_FLASH_DISCOVERY_TIERSmapping forgemini-3.7-flash-low|medium|highand their corresponding thinking levels insrc/providers/antigravity-models.ts.resolveAntigravityEffortWireModelto prioritize mapping current Flash discovery tier IDs toGEMINI_FLASH_WIRE_ID(gemini-3.7-flash-tiered) with the matchingthinkingLevelbefore the suffix/alias branch.tests/google-antigravity-wire.test.tsto assert resolver output and adapter request payload include thethinkingConfigforlow,medium, andhighpartial discovery rows.Testing
bun test tests/google-antigravity-wire.test.tsand the modified file's tests passed (51 tests, focused Antigravity tests passed including the new assertions).bun run typecheckand it completed successfully (bun x tsc --noEmit).bun run testin this environment but it was environment-limited: GUI dependency installs returned HTTP 403 and an unrelated timeout/epoll error occurred, so unrelated integration tests failed in this environment while the focused Antigravity tests and typecheck succeeded locally.Codex Task