Skip to content

[WRONG BRANCH] fix(lab): ensure manual Lab runs are cancellable during shutdown - #288

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-lab-shutdown-issue
Draft

[WRONG BRANCH] fix(lab): ensure manual Lab runs are cancellable during shutdown#288
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-lab-shutdown-issue

Conversation

@luvs01

@luvs01 luvs01 commented Aug 15, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Prevent manual /api/lab/automation/run executions from continuing past drainAndShutdown when Lab was never activated, by ensuring manual runs register a shutdown hook so they are cancelled like other Lab activities.

Description

  • Register a run-scoped optional shutdown hook for manual dispatches in src/lab/automation/orchestrator.ts using registerOptionalShutdownHook(...) and detach it in a finally block so the hook cannot leak after completion.
  • Add an outcome-level regression test in tests/lab-automation-review-regressions.test.ts that starts a manual run, releases the activation lease, invokes runOptionalShutdownHooks(), and asserts the manual run is cancelled.
  • Reset optional-shutdown-hooks in the test teardown to avoid cross-test leakage.

Testing

  • Ran git diff --check and created the fix commit (fix(lab): cancel manual runs during shutdown).
  • Ran bun run typecheck (local run) which completed without type errors for the edited modules.
  • Executed the focused test run bun test tests/lab-automation-review-regressions.test.ts, which failed during module load with a Bun/runtime node:zlib export incompatibility (zstdDecompressSync) unrelated to this change; the failure prevented the full focused-suite execution in this environment.
  • tests/optional-shutdown-hooks.test.ts (focused) was not fully exercised due to the prior runtime error; the new tests exercise the optional-shutdown-hooks path and were authored alongside the fix.

Codex Task

@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 3d6bad5c-aef7-4099-b907-472f86e92b9d

📥 Commits

Reviewing files that changed from the base of the PR and between 161c09f and 37b3d5b.

📒 Files selected for processing (2)
  • src/lab/automation/orchestrator.ts
  • tests/lab-automation-review-regressions.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 15, 2026
@github-actions github-actions Bot changed the title fix(lab): ensure manual Lab runs are cancellable during shutdown [WRONG BRANCH] fix(lab): ensure manual Lab runs are cancellable during shutdown Aug 15, 2026
@github-actions

github-actions Bot commented Aug 15, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 15, 2026 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant