Skip to content

[WRONG BRANCH] fix(scripts): run ocx-run commands in the requested workdir #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
luvs01 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WRONG BRANCH] fix(scripts): run ocx-run commands in the requested workdir #287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/ocx-run
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ echo "started=$(date -Is) name=$name limit=$limit cmd=$*" > "$status"

# setsid gives the job its own process group so a timeout kills the children too;
# --kill-after upgrades to SIGKILL for a process that ignores SIGTERM.
setsid timeout --signal=TERM --kill-after=60s "$limit" "$@" > "$log" 2>&1 &
(cd "$workdir" && exec setsid timeout --signal=TERM --kill-after=60s "$limit" "$@") > "$log" 2>&1 &

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Treat hyphen-leading workdirs as paths

When scripts/ocx-run receives a valid relative workdir named -, the preceding -d check succeeds, but Bash interprets cd "-" as a request to switch to $OLDPWD; the wrapped command therefore succeeds in the wrong directory. Other hyphen-leading directory names can instead be parsed as invalid options. Use cd -- "$workdir" (or canonicalize the path) so every validated workdir is treated as a directory operand.

Useful? React with 👍 / 👎.

job=$!
echo "$job" > "$pidf"

Expand Down
Loading