Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/usage/log.ts
Original file line number Diff line number Diff line change
Expand Up @@ -841,6 +841,10 @@ async function readUsageEntriesIncrementally(
// A shrink means truncation or replacement-in-place; the retained rows may no
// longer correspond to file contents, so refuse to extend them.
if (size < retained.coveredThroughBytes) return null;
// Extending retained state is only an optimization; never let a large burst turn
// the bounded management read into an unbounded read of everything appended since
// the previous poll. A full read below will load only the requested tail window.
if (size - retained.coveredThroughBytes > maxReadBytes) return null;
// Verify the retained REGION is unchanged before anything is reused. Identity keeps
// dev/ino/birthtime, and an append and an in-place rewrite both move mtime/ctime
// forward, so only the bytes themselves settle it.
Expand Down
29 changes: 29 additions & 0 deletions tests/api-usage.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -578,6 +578,35 @@ describe("GET /api/usage", () => {
}
});

test("an append burst larger than the byte window falls back to a bounded full read", async () => {
const now = Date.now();
const maxReadBytes = 512;
const row = (id: string): string => `${JSON.stringify({
requestId: id,
timestamp: now,
provider: "openai",
model: "gpt-5.5",
status: 200,
durationMs: 1,
usageStatus: "reported",
usage: { inputTokens: 1, outputTokens: 1 },
totalTokens: 2,
})}\n`;
const path = join(testDir, "usage.jsonl");
writeFileSync(path, row("seed"));

await usageLogModule.readUsageSnapshotForManagement(maxReadBytes);
const parsedBeforeBurst = usageReadCacheStatsForTests().parsedLines;
appendFileSync(path, Array.from({ length: 100 }, (_, index) => row(`burst-${index}`)).join(""));

const snapshot = await usageLogModule.readUsageSnapshotForManagement(maxReadBytes);
const stats = usageReadCacheStatsForTests();
expect(stats.fullReads).toBe(2);
expect(stats.tailReads).toBe(0);
expect(stats.parsedLines - parsedBeforeBurst).toBe(snapshot.entries.length);
expect(snapshot.entries.length).toBeLessThan(100);
});

test("appends to an over-window ledger stay incremental and bounded", async () => {
const now = Date.now();
writeFixture(now);
Expand Down
Loading