Skip to content

Phase19e loopback integration test #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
JustinKovacich wants to merge 2 commits into
base: feature/phase19c_embassy_net_socket_io
Choose a base branch
from
Draft

Phase19e loopback integration test #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10fdfdc
phase 19e: adapter-level loopback test (LoopbackDriver pair + UDP rou…
JustinKovacich Apr 29, 2026
96f6afa
phase 19e: lockfile update for tokio/futures dev-deps
JustinKovacich Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 12 additions & 3 deletions simple-someip-embassy-net/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,21 @@ embassy-sync = "0.6"
heapless = "0.9"

[dev-dependencies]
# Host-side tests use a tuntap-backed embassy-net stack to drive a
# request/response roundtrip. The dev-dep is what gets us link-time
# `critical-section` impls on the host.
# Host-side tests run two embassy-net stacks bridged by a software
# `LoopbackDriver` pair (no kernel TUN, no privilege requirement).
# `critical-section/std` provides a host platform impl so embassy-sync
# / embassy-net link on host; firmware supplies its own.
critical-section = { version = "1", features = ["std"] }
embassy-executor = { version = "0.6", features = [
"arch-std",
"executor-thread",
] }
embassy-time = { version = "0.3", features = ["std", "generic-queue-8"] }
# Tokio drives the test harness — `#[tokio::test]` for setup,
# `tokio::spawn` for the per-stack `Stack::run()` futures, and
# `tokio::time::timeout` for bounded assertions. Same shape as the
# parent crate's `tests/bare_metal_e2e.rs` harness.
Comment on lines +62 to +64
Copy link

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments say the harness uses tokio::spawn for the per-stack Stack::run() tasks, but the test uses tokio::task::spawn_local (required by LocalSet / current_thread). Updating the comment will avoid confusion about why rt-multi-thread isn’t actually needed for the test.

Suggested change
# `tokio::spawn` for the per-stack `Stack::run()` futures, and
# `tokio::time::timeout` for bounded assertions. Same shape as the
# parent crate's `tests/bare_metal_e2e.rs` harness.
# `tokio::task::spawn_local` for the per-stack `Stack::run()` futures
# within a `LocalSet` / current-thread runtime, and
# `tokio::time::timeout` for bounded assertions. Same overall shape as
# the parent crate's `tests/bare_metal_e2e.rs` harness.

Copilot uses AI. Check for mistakes.
tokio = { version = "1", features = ["rt-multi-thread", "macros", "time", "sync"] }
# `futures` brings `select_biased!` / `FusedFuture` / `pin_mut!` into
# scope for the test driver.
futures = "0.3"
Comment on lines +66 to +68
Copy link

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The crate adds futures = "0.3" as a dev-dependency, but there’s no code in simple-someip-embassy-net (including tests/loopback.rs) that actually uses the futures crate right now. Consider dropping this dev-dep until it’s needed (or add the missing usage) to keep the dependency surface minimal.

Suggested change
# `futures` brings `select_biased!` / `FusedFuture` / `pin_mut!` into
# scope for the test driver.
futures = "0.3"

Copilot uses AI. Check for mistakes.
Loading