Skip to content

Suppress placeholder BMS faults during startup grace #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukash merged 1 commit into from
Jul 24, 2026
+5 −3
Merged

Suppress placeholder BMS faults during startup grace #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/bms.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,11 @@ void bms_update(BMS *bms, const CfgBMS *cfg, const Time *time) {
const float timeout = 5.0f;

// Before the first BMS update occurs right after startup, msg_age has its
// init value. We need to wait the `timeout` time before issuing errors.
if (bms->msg_age > timeout && time_elapsed(time, start, timeout)) {
set_fault(&fault_mask, BMSF_CONNECTION);
// init value. Suppress all telemetry faults until the grace period expires.
if (bms->msg_age > timeout) {
if (time_elapsed(time, start, timeout)) {
set_fault(&fault_mask, BMSF_CONNECTION);
}
bms->fault_mask = fault_mask;
return;
}
Expand Down
Loading