chore: build playground before deploying to github pages#100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Ensure the playground's production bundle is built before the GitHub Pages deploy step runs, so the deployed site reflects the current release instead of stale or missing build output.
What was done
Build Playgroundstep in.github/workflows/release-and-publish.ymlthat runsyarn nx run-many --target=build --projects=playgroundimmediately before theDeploy Playground to Github Pagesstep.if: github.event.inputs.dry_run != 'true', mirroring the existing deploy step so dry-run executions still skip both build and deploy.Test plan
release-and-publishworkflow withdry_run=trueand confirm the new Build Playground step is skipped along with the deploy step.dry_run=falseand confirm the Build Playground step runs successfully and produces the artifact consumed by the deploy step.