Repository navigation
fix(webui): docs dialog blocked by CSP frame-src - #228
Merged
Merged
Conversation
The docs dialog frames /go/docs, which 302s to the docs site; frame-src only allowed 'self' and streamdeck:, so the redirect was blocked. Add the docs origin. Docs pages framed in the dialog now open localhost links in a new tab (WebUI forbids framing).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs dialog frames /go/docs, which redirects to the docs site. CSP checks each redirect hop and frame-src lacked the docs origin, so the docs never loaded (regression from #227). Adds the origin (from DOCS_BASE) plus a CSP test.
Also: docs pages shown in the dialog now open localhost:3000 links in a new tab, because the WebUI sets frame-ancestors 'none'.