ci(scorecard): stop filing repository grades as code-scanning alerts - #41
Conversation
|
Warning Review limit reached
Next review available in: 83 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Scorecard workflow removes ChangesScorecard workflow permissions
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change stops publishing repository-practice grades as code-scanning alerts while preserving Scorecard results and artifacts; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What changed
The OpenSSF Scorecard job no longer uploads its results to code scanning. It still runs, still publishes to the public Scorecard API that backs the badge and viewer, and still keeps the raw SARIF as a build artifact. The job's
security-events: writepermission is dropped because nothing in it writes alerts now.Why
Scorecard grades repository practice: whether actions are pinned to digests, whether branch protection is on, what share of pull requests carried an approving review. Code scanning is the surface for defects in this repository's code. Uploading the grade into that surface files each check as a dismissible alert carrying a severity, which is a different claim from the one Scorecard makes.
Those alerts also do not stay dismissed. GitHub matches results across uploads by rule and fingerprint, and a result whose identity shifts arrives as a new alert that an earlier dismissal does not cover. Two alerts in this repository reported the same finding at the same file and line on consecutive days. One rule accumulated 25 separate alert numbers over five months, and a false positive was dismissed under four different numbers. The result was a standing queue of security-labelled items that no code change could close, which trains a reader to clear the queue without reading it.
What this does not do
It does not hide the grade.
publish_resultscontinues to send results to the public OpenSSF Scorecard API, so anyone can read this repository's score and its per-check detail without asking. The artifact keeps the raw SARIF for the run.It also does not claim that code scanning now holds only genuine findings. Scorecard's own vulnerability check reports advisories that remain worth reading; they are read from the Scorecard result rather than from an alert list. Anyone auditing this repository should look at both.
CodeQL is unaffected. It uploads its own SARIF from a separate job with its own permission, and it remains a required check.
Summary by CodeRabbit