[Repo Assist] eng: add strict warning flags to Windows build#160
Draft
github-actions[bot] wants to merge 1 commit into
Draft
[Repo Assist] eng: add strict warning flags to Windows build#160github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Add strict warning flags to the Windows build script (build_parallel.ps1) to match the strictness already applied on Linux/ARM builds in Taskfile. Compiler warnings are treated as errors across the project; this change ensures Windows builds surface the same class of issues. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist.
Summary
Add
-Wall -Wextra -Wpedantic -fno-builtinto the Windows build scriptbuild_parallel.ps1, matching the strict warning flags already used on Linux/ARM inTaskfile.Motivation
The project convention treats compiler warnings as errors. Linux and ARM builds already compile with these flags. The Windows build script was missing them, creating a gap where Windows-specific code could silently introduce warnings that would be errors on other platforms.
Change
Single-line change in
build_parallel.ps1: add four warning flags after the include paths.Test Status
Linux x86-64: all 9 test binaries pass. Windows CI will confirm no new warnings are introduced.