Repository navigation
workflows: -new-gke.tfvars -> -gke.tfvars - #960
Merged
Merged
Conversation
fajpunk
force-pushed
the
u/danfuchs/no-longer-new
branch
from
October 5, 2026 15:09
b605b3d to
b4a4ccc
Compare
dspeck1
approved these changes
Oct 5, 2026
dspeck1
left a comment
dspeck1
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. The RSP Int plan had changes to user lab pool to add more zones. I would consider breaking Prod into a separate change to give flexibility on the apply. The state prefixes still have the new path. That is fine. Just noting in case you wanted to remove the old state prefixes and move the new into those paths.
Contributor
Author
|
Yeah, I decided not to mess with the state prefixes. There's another PR that enshrines the node pool AZ changes, I'm fine reverting them when I merge this if that other PR isn't merged by then. I'm planning on merging this during the patch window, so I think we're good keeping it as one change for now. |
fajpunk
force-pushed
the
u/danfuchs/no-longer-new
branch
2 times, most recently
from
October 8, 2026 22:16
785f197 to
07b80e3
Compare
Now that all of the clusters have been rebuilt and the old clusters destroyed, the existing clusters are no longer "new"
fajpunk
force-pushed
the
u/danfuchs/no-longer-new
branch
from
October 8, 2026 22:18
07b80e3 to
91bc561
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that all of the clusters have been rebuilt and the old clusters destroyed, the existing clusters are no longer "new"