DM-54825: Add template mask columns to coadd_depth_table. - #495
erinleighh wants to merge 2 commits into
Conversation
eb76711 to
67d111d
Compare
67d111d to
679628f
Compare
| rejected_flag = (mask_array & rejected) != 0 | ||
| inexact_psf_flag = (mask_array & inexact_psf) != 0 | ||
| intrp_flag = (mask_array & intrp) != 0 | ||
|
|
There was a problem hiding this comment.
Please remove the blank lines unless they're here for a purpose I'm missing. (And if you used an LLM to help with these code changes, please say so in the commit message.)
There was a problem hiding this comment.
Will do! No LLM on this one, mostly me wanting space to read things better (and fighting with lint/black). I'll clear out the blank lines!
| ) | ||
|
|
||
|
|
||
| class CoaddDepthSummaryTask(PipelineTask): |
There was a problem hiding this comment.
Please add task documentation per https://developer.lsst.io/python/numpydoc.html#documenting-classes
There was a problem hiding this comment.
Genuinely surprised this wasn't caught in the initial ticket and I completely spaced on it twice. Thank you!
| @@ -80,24 +89,107 @@ | |||
| butlerQC.put(outputs, outputRefs) | |||
|
|
|||
| def run(self, inputs): | |||
There was a problem hiding this comment.
Please add method documentation per https://developer.lsst.io/python/numpydoc.html#documenting-methods-and-functions
In particular, what is expected to exist in inputs ?
| + list(zip(*stats)) | ||
| + list(zip(*quantiles)) | ||
| ) | ||
| names = ["patch", "band", "mean", "median", "stdevs"] + threshold_col_names + quantile_col_names |
There was a problem hiding this comment.
Should stdev be singular here to match its friends in names?
There was a problem hiding this comment.
Oops, good catch. Thanks!!
| n_image_table = Table(data=data, names=names, dtype=dtype) | ||
|
|
||
| # Combine tables. | ||
| combined_table = join(coadd_table, n_image_table, keys=["patch", "band"]) |
There was a problem hiding this comment.
For clarity I suggest importing the entirety of astropy.tables and explicitly calling this astropy.tables.join here, but it's not essential.
2 participants
No description provided.