DM-55321: Add a config parameter to analysis_tools base to switch on/off plot generation - #490
Open
jrmullaney wants to merge 8 commits into
Open
jrmullaney wants to merge 8 commits into
jrmullaney wants to merge 8 commits into
Conversation
sr525
reviewed
Sep 14, 2026
sr525
reviewed
Sep 14, 2026
sr525
reviewed
Sep 17, 2026
| task = _make_task({"nStars": "ct"}) | ||
| handles = _make_handles([{}, {}, {}]) | ||
| with self.assertRaises(UpstreamFailureNoWorkFound): | ||
| task._collectData(handles, "myTask") |
Collaborator
There was a problem hiding this comment.
Is there a count of how many that don't have any/all metrics?
jrmullaney
force-pushed
the
tickets/DM-55321
branch
from
October 2, 2026 14:25
9a7fc67 to
116d4a1
Compare
With aggregates now calculated in visitQualityCore, move the visit-detector level calibrateImage_metadata metrics to visitQualityExtended for use when one-off visits need inspecting.
Drive-by: catalogMatchVisit appears in both visitQualityExtended and visitQualityCore. This can produce a task-name-clash if both yamls are imported. Rather than rename one of them, I'm removing the instance in visitQualityExtended, as visitQualityExtended should always follow a run of visitQualtyCore, either in the same run or as an afterburn.
This addition allows plots to be turned off at the task level so that none of the atools generate any of their plots.
jrmullaney
force-pushed
the
tickets/DM-55321
branch
from
October 2, 2026 14:26
116d4a1 to
7e851a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.