Skip to content

Use typed readers in provider appenders - #11

Merged
lqlive merged 1 commit into
mainfrom
feature/provider-typed-appender-fast-path
Jun 18, 2026
Merged

lqlive merged 1 commit into
mainfrom
feature/provider-typed-appender-fast-path

Conversation

@lqlive

@lqlive lqlive commented Jun 18, 2026

Copy link
Copy Markdown
Owner

Summary

  • Switch MySQL, PostgreSQL, and SQLite appenders to provider-specific typed readers.
  • Replace generic GetValue/Convert conversions in database provider appenders with typed reader getters.
  • Keep ClickHouse on DbDataReader while using typed getter methods where available.

Test plan

  • dotnet build src/Apache.DataFusion.TableProviders.MySql/Apache.DataFusion.TableProviders.MySql.csproj -c Debug --nologo -v q
  • dotnet build src/Apache.DataFusion.TableProviders.PostgreSql/Apache.DataFusion.TableProviders.PostgreSql.csproj -c Debug --nologo -v q
  • dotnet build src/Apache.DataFusion.TableProviders.ClickHouse/Apache.DataFusion.TableProviders.ClickHouse.csproj -c Debug --nologo -v q
  • dotnet build src/Apache.DataFusion.TableProviders.Sqlite/Apache.DataFusion.TableProviders.Sqlite.csproj -c Debug --nologo -v q
  • dotnet test tests/Apache.DataFusion.Tests/Apache.DataFusion.Tests.csproj --nologo -v q

Avoid generic DbDataReader.GetValue conversion in database table providers so row-to-Arrow conversion follows each driver's typed reader path.

Co-authored-by: Cursor <cursoragent@cursor.com>
@lqlive
lqlive merged commit 9bfc455 into main Jun 18, 2026
4 checks passed
@lqlive
lqlive deleted the feature/provider-typed-appender-fast-path branch June 18, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant