Add todo reporting#67
Open
richardcocks wants to merge 5 commits into
Open
Conversation
Owner
|
Hello! Are you still working on this? |
Author
|
Sorry, I thought I had marked it ready for review already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Satisfies #61
This adds todo reporting as a separate category in the final summary.
When there are only failing todos and no failures from asserts or panics, then this will show yellow, but still exit code 1, so will still fail in CI environments, to maintain compatibility with current behaviour.
There are a number of accomodations that had to be made to get this tested within this repository. I had to suppress the raw test output, so that it is not confused with the tests being asserted in the test module. Then in order to that in a compatible way, I had to special case Node and Deno handling.