Add CHERI Mocha part number#9
Conversation
marnovandermaas
left a comment
marnovandermaas
left a comment
There was a problem hiding this comment.
Just a few comments from my end.
| [darjeeling]: https://github.com/lowRISC/opentitan/blob/8f279ef47ba3a5c95f1416612b4f5efe8304ee0b/hw/top_darjeeling/rtl/jtag_id_pkg.sv | ||
| [demo-system]: https://github.com/lowRISC/ibex-demo-system/blob/af43c851580c89d0f24d9010865faeb0b32af1ee/rtl/system/jtag_id_pkg.sv | ||
| [sonata]: https://github.com/lowRISC/sonata-system/blob/71f2a24425d10df38107a2ae8f954400a366047f/rtl/system/jtag_id_pkg.sv | ||
| [mocha]: https://github.com/lowRISC/mocha |
There was a problem hiding this comment.
Can we make this pull request once we have a JTAG ID package merged into Mocha? This way we can have the same link as we have for the other projects.
There was a problem hiding this comment.
Yes, there is a bit of a dependency-loop here. I propose we decide on the IDCODE value in this PR, then the debug module is merged into Mocha, then I update this PR with the full link and merge it.
| | 1 | 1 | [OpenTitan Darjeeling][darjeeling] | ||
| | 1 | 256 | [Ibex Demo System][demo-system] | At present Ibex Demo System has no strict versioning so all instances will use version 1 | ||
| | 1 | 257 | [Sonata system][sonata] | ||
| | 1 | 258 | [CHERI Mocha][mocha] |
There was a problem hiding this comment.
Maybe it would be good to keep this ID chain for FPGA-only systems like the demo system and Sonata. Maybe we can start another range at 384?
There was a problem hiding this comment.
I'd probably bump it all the way to 512 in that case, so that the upper-nybble is used to classify as follows: 0=OpenTitan, 1=FPGA-only, 2=COSMIC/Mocha
There was a problem hiding this comment.
I think that is a good suggestion, as it gives us 13 remaining "classifications" in the upper nybble and ample space within each classification. If we agree on this, I suggest we add it to this document.
There was a problem hiding this comment.
I have adjusted the PR to reflect the proposed changes (although I mis-remembered "classifications" as 'categorisations'). I'm happy to take suggestions for changes to the category names or anything else. For example, I'm uncertain whether to use "CHERI Mocha" or something broader for the group description at this stage.
| | 1 | 1 | 3 | [OpenTitan Darjeeling][darjeeling] combined TAP | ||
| | 1 | 256 | 1 | [Ibex Demo System][demo-system] RV_DM RISC-V debug module | ||
| | 1 | 257 | 1 | [Sonata System][sonata] RV_DM RISC-V debug module | ||
| | 1 | 258 | 1 | [CHERI Mocha][mocha] |
There was a problem hiding this comment.
The complete description should be [CHERI Mocha][mocha] RV_DM RISC-V debug module, right?
New Part Type scheme proposed where the upper nybble categorises the the part by project. Allocate a new category and part for CHERI Mocha. The link to Mocha is only to the repository rather than the JTAG IDCODE-defining file as the debug module has not yet been merged.
elliotb-lowrisc
force-pushed
the
elliotb-mocha-1
branch
from
360787e to
fa621fd
Compare
4 participants
As Mocha is another non-OpenTitan project, I chose the part number after Sonata.
The link to Mocha is only to the repository rather than the JTAG IDCODE-defining file as the debug module has not yet been merged. This PR will be updated with the full link once we have agreed on an IDCODE and the changes have been merged into Mocha.