Skip to content

[uart,dv] V1 sign-off checklist#606

Open
csabakiss-semify wants to merge 1 commit into
lowRISC:mainfrom
csabakiss-semify:csk_uart_v1_signoff
Open

[uart,dv] V1 sign-off checklist#606
csabakiss-semify wants to merge 1 commit into
lowRISC:mainfrom
csabakiss-semify:csk_uart_v1_signoff

Conversation

@csabakiss-semify

Copy link
Copy Markdown
Collaborator

V1 sign-off for UART. This pull request should have three approvers before merging.

@martin-velay

Copy link
Copy Markdown
Contributor

I could confirm that UART is part of a daily regression and the results are satisfying V1 goals:
image

@martin-velay martin-velay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, this block is ready for V1. Thanks Csaba

@marnovandermaas marnovandermaas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment, can we remove the mention of V2S?

Comment thread doc/proj/uart.md
| Integration | PRE_VERIFIED_SUB_MODULES_V1 | Waived | UART and its primitive submodules are vendored from OpenTitan, where UART reached V3 ([OpenTitan UART sign-off][]); Mocha applies no functional RTL patches |
| Review | DESIGN_SPEC_REVIEWED | Waived | The specification was reviewed through the OpenTitan sign-off process and the block is imported without functional changes |
| Review | TESTPLAN_REVIEWED | Done | The vendored [OpenTitan UART checklist][] records the testplan review as complete |
| Review | STD_TEST_CATEGORIES_PLANNED | Done | Error scenarios, performance and stress tests are covered in the [UART testplan][]; security bus-integrity testing is planned at V2S; power and debug are N/A |

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V2S is not currently a thing that we plan to do in Mocha, maybe we can state that the bus integrity check is currently out of scope for Mocha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants