Skip to content

feat: Enable the error reporting feature by default - #487

Merged
kirre-bylund merged 1 commit into
release/v8.2.0from
feat/enable-error-reporting-by-default
Sep 22, 2026
Merged

kirre-bylund merged 1 commit into
release/v8.2.0from
feat/enable-error-reporting-by-default

Conversation

@kirre-bylund

Copy link
Copy Markdown
Contributor

Summary

Removes the LOOTLOCKER_BETA_ENABLE_ERROR_REPORTING compile-time gate so the SDK error reporting feature is enabled by default.

The supporting implementation (LootLockerFailedRequestReport, TryGetFailedRequestReportForRequestId, StoreFailedRequestReport) was already unguarded — only the public entry point and the call site were behind the ifdef. This change removes the remaining gates.

Changes

  • Runtime/Game/LootLockerSDKManager.cs — un-gate SendLootLockerErrorReport
  • Runtime/Client/LootLockerResponse.cs — un-gate ReportFailure
  • Runtime/Client/LootLockerHTTPClient.cs — un-gate the StoreFailedRequestReport call site

Notes

  • No behavioural change other than the feature now being available without defining a compile symbol.
  • The backend endpoint (POST error-report) and admin routes are already live; error_reports in usage/feature.go is usage-tracking only, not a hard gate.

Testing

  • Unity compile
  • Manual verification of a failed request producing an error report

Copilot AI lite review requested due to automatic review settings September 22, 2026 07:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The remaining gates are removed consistently and the existing implementation is otherwise unchanged.

Review effort: Lite
Findings: None

What changed in this PR

Removes the beta compile-time gates so error reporting is available by default.

Changes:

  • Exposes SendLootLockerErrorReport.
  • Exposes LootLockerResponse.ReportFailure.
  • Enables failed-request report storage.
File Description
Runtime/​Game/​LootLockerSDKManager.cs Ungates the public error-report API.
Runtime/​Client/​LootLockerResponse.cs Ungates ReportFailure.
Runtime/​Client/​LootLockerHTTPClient.cs Ungates failure-report storage.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@kirre-bylund
kirre-bylund merged commit 37a2dc1 into release/v8.2.0 Sep 22, 2026
3 checks passed
@kirre-bylund
kirre-bylund deleted the feat/enable-error-reporting-by-default branch September 22, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants