Repository navigation
docs(site): fix right-edge CLI clipping in context-native-path-v10 SVGs - #7919
Conversation
loopx-agent
left a comment
There was a problem hiding this comment.
Review Summary (7fa40ea374be3e41ef532fbcb0b0152cc2112a6b)
- Scope: Public blog static SVG diagrams under
apps/presentation/site/public/blog/images/context-delivery/(context-native-path-v10.svg,context-native-path-v10-en.svg,context-cycle-v9.svg,context-cycle-v9-en.svg). No control-plane, runtime, or CLI behavior changes. - Verification: Wrapped the three long
quota context-readCLI commands in Column C (Cards ②, ③, ④) across two lines so text bounding boxes remain insidex=952..1290 < 1302(card right edge) and< 1360(viewBoxwidth); verified PNG rasterization via WebKit andgit diff --checkclean.
Verdict: Approved for merge on exact head 7fa40ea374be3e41ef532fbcb0b0152cc2112a6b.
|
This pull request has merge conflicts with Choose the remote for the base repository, not an out-of-date fork. git fetch upstream
git rebase upstream/main
# Resolve each conflict, git add the resolved files, then git rebase --continue.
git push --force-with-lease origin HEADFor a same-repository clone whose Keep the DCO |
…h SVGs Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
7fa40ea to
43e02b1
Compare
There was a problem hiding this comment.
Reviewer: model_agent; gemini-2.5-pro; Google DeepMind; self_reported; reasoning_effort=high
Approval conclusion (author-owned PR; GitHub blocks formal self-approval)
Reviewed exact head: 7919@43e02b1cf831e8310b495368828f21c17f7e7149
动机 / Motivation
在主干合入 PR #7921(eb153fafb0,将 context-native-path-v10.svg 与 context-native-path-v10-en.svg 高度调整为 1020 并修复面板内换行)后,右列(Column C)命令卡片 ②、③、④ 的第一行省略了 quota context-read 子命令前缀(仅保留 --reference-file "$REC" ... 与 --capture-file projection.json ...),与卡片 ①(quota context-read --reference-file "$REF" --initial-read)不一致。本 PR 基于最新 origin/main(58a85d0aae)补回完整的 quota context-read 子命令前缀并保持双行 <tspan> 不越界。
改动思路 / Approach
在保留 #7921 的 1360x1020 画布与面板高度基础上,仅将 context-native-path-v10.svg 与 context-native-path-v10-en.svg 中卡片 ②、③、④ 的首行 <tspan> 补齐为 quota context-read --reference-file "$REC" \ 与 quota context-read --capture-file projection.json \,次行缩进展示 --select / --list 参数,确保所有行宽度严格位于 x=938..1302(364px)卡片内部。
具体改动 / Changes
apps/presentation/site/public/blog/images/context-delivery/context-native-path-v10.svg:在卡片 ②(第 99 行)、③(第 104 行)、④(第 109 行)首行恢复quota context-read前缀与续行符\。apps/presentation/site/public/blog/images/context-delivery/context-native-path-v10-en.svg:同步恢复英文版卡片 ②、③、④ 首行的quota context-read前缀与续行符\。
对主干的风险 / Risks
- 静态资源边界:仅修改
apps/presentation/site/public/blog/images/context-delivery/下的两个静态 SVG 文件(+6 / -6行),不触碰任何控制面、运行时、CLI 或协议代码。 - 验证状态:
git diff --check:PASS(无空白字符或尾随空格告警)。- WebKit/AppKit
1360x1020渲染回读:PASS(中英双语卡片 ②、③、④ 完整显示quota context-read且右侧留有充足内边距,无裁切)。 - 公开安全扫描:PASS(不含任何私有路径、凭证或内部上下文)。
我的整体评价 / Verdict
APPROVE — 本次改动严格限定在 apps/presentation/site/public/blog/images/context-delivery/ 下的两张静态 SVG 配图(+6 / -6 行),基于 origin/main 最新 58a85d0aae 补齐了卡片 ②、③、④ 的 quota context-read 完整子命令前缀,且通过 1360x1020 实际光栅化视觉回读确认中英双语均无右侧越界裁切,符合静态文档配图自审合并标准。
English verdict: APPROVE — 7919@43e02b1cf831e8310b495368828f21c17f7e7149 cleanly restores the full quota context-read subcommand prefix across Cards ②, ③, and ④ in context-native-path-v10.svg and context-native-path-v10-en.svg on top of 58a85d0aae without horizontal clipping (git diff --check and 1360x1020 visual readback PASS).
Summary
[P2]review finding on PR docs(blog): embed bilingual v10 architecture and continuity diagrams in context-delivery article #7884 where the single-line CLI commands in Column C (Cards ②, ③, ④) ofcontext-native-path-v10.svgandcontext-native-path-v10-en.svgoverflowed the364pxcard width (x=938..1302) and the1360pxSVGviewBox.quota context-readcommands across two lines inside their respective cards (x=952..1290 < 1302) and removes trailing whitespace on line 4 across all four Context Delivery blog SVGs (git diff --checkclean).