Repository navigation
Conversation
Escape correctly dismisses an open context-help popover before its parent reader. Use the close control and wait for the analysis reader to disappear before asserting that selecting an unanalysed source does not open or execute analysis. Signed-off-by: duang777 <duangjl007@gmail.com>
Duang777
requested review from
huangruiteng,
loopx-agent and
songoow
as code owners
October 24, 2026 05:50
This was referenced Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposal is absorbed into #7209 at
35e99bf, retaining its separate signed commit. Closing this duplicate proposal lets one branch qualify both current-main CI failures.Summary
The research-history smoke assumes one Escape closes analysis, but an open context-help popover correctly consumes Escape first. Close analysis explicitly and wait for the reader to disappear before testing an unanalysed scope.
Evidence
Merge Danger
Door: two-way
Blast Radius: tests
Only two smoke lines change. The application's Escape priority and analysis behavior are unchanged.
Goal And Delivered Outcome
659c1fd.Author Declaration
Implemented against
research-history.mjsno-analysis-write and help-dismissal assertions at659c1fd.Scope And Continuation
Validation
a85c4e72cbb79a25d8b0f2620754e8995b3753a2.Frontend / Visual Evidence
Type of Change
LoopX Area
Technical Direction
Shared-authority RFC fixture impact
Boundary Checklist