Skip to content

refactor(inbox): consolidate native read transport in the IO boundary - #6903

Closed
loopx-agent wants to merge 1 commit into
mainfrom
codex/inbox-read-transport-20261020
Closed

loopx-agent wants to merge 1 commit into
mainfrom
codex/inbox-read-transport-20261020

Conversation

@loopx-agent

Copy link
Copy Markdown
Collaborator

The native Inbox read transport lived in an extra Python module that called back into the existing Inbox IO module for its clock. Its callers already belong to that IO boundary, and the additional module pushed the maintained Python/TypeScript pair ratchet to 44 against its budget of 43.

Consolidate the transport in the existing collaboration/inbox.py, update its actual callers and remove inbox_read.py. The TypeScript transaction owner, operation names, scope facts, snapshot routing, error classification and persisted data remain unchanged. The existing source-appearance regression retains its assertions and patches the consolidated transport location.

Validation at 2fc67db407727b5572167215afe80a3b27dd76ca:

  • 337 native Inbox, manager-context, pagination, receipt recovery, Goal-instance and delegation tests passed; 35 TypeScript owner tests passed.
  • The same semantic-ratchet command fails with 44/43 on immutable main 764b989dce88ef43ade5aba5af4958ee2cf3a821 and passes with 43/43 here. No budget, exemption or TypeScript decision code changed.
  • The transport function's executable AST is preserved after imports/docstrings are normalized; actual native tests cover large snapshots, failure recovery, identity, receipt and result paths.
  • Ruff, diff hygiene, semantic advisory, bilingual diff check and the complete selected premerge checks passed.

This is an IO consolidation with no frontend or lifecycle behavior change. It also removes the inherited validation blocker encountered while qualifying the original-runtime Goal analysis in #6878.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
@mergify

mergify Bot commented Oct 19, 2026

Copy link
Copy Markdown

This pull request has merge conflicts with main and cannot be merged
until they are resolved. Please rebase or merge the base branch, @loopx-agent.

Choose the remote for the base repository, not an out-of-date fork.
For a fork clone, first inspect git remote -v; upstream must point
to https://github.com/loopx-project/loopx.git. If it is absent, add it
with git remote add upstream https://github.com/loopx-project/loopx.git.
Then run:

git fetch upstream
git rebase upstream/main
# Resolve each conflict, git add the resolved files, then git rebase --continue.
git push --force-with-lease origin HEAD

For a same-repository clone whose origin points to
https://github.com/loopx-project/loopx.git, use origin instead of
upstream for fetch/rebase. If you prefer merging the base, use
git merge <base-remote>/main and push normally.

Keep the DCO Signed-off-by trailer on every commit when you rebase.
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase Mergify: the pull request has merge conflicts with its base branch label Oct 19, 2026
@loopx-agent

Copy link
Copy Markdown
Collaborator Author

关闭为已覆盖:#6896 已在 main 完成相同 Inbox 读取传输合并。当前 main 与本 PR 的 read_inbox_transaction 可执行 AST 相同,调用方迁移一致,仅函数位置、注释与测试局部别名不同,没有独立行为增量。保留本 PR 的 337 项 Python、35 项 TypeScript 和完整 premerge 通过记录;不重复合并,也不放宽模块预算。#6878 的原实验 Goal 分析路径已在 main。

Closing as superseded by #6896: the same native Inbox transport consolidation and caller migration are already on main. This head adds no independent behavior, so another merge would only duplicate the delivered change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Mergify: the pull request has merge conflicts with its base branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant