Repository navigation
Conversation
Signed-off-by: song <liusongstep@gmail.com>
Collaborator
Author
|
Folded into |
Signed-off-by: song <liusongstep@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and delivered behavior
An agent can optimize for an earlier first signal by presenting an unnecessarily weak artifact, then describe recovery from that low start as useful long-horizon gain. Shared product planning and enabled stride review should distinguish initial deliverable quality, latency/cost and improvement beyond the retained best.
The common Goal planner now carries
first_delivery_guidance, also rendered into guided start prompts and consumed by the existingtodo planpacket. It asks for a strong feasible first deliverable with coherent implementation/validation, preserves useful diagnostic probes and original acceptance/feedback/authority limits, and rejects indefinite preparation as the objective.The existing TypeScript stride review questions distinguish initial quality from later gain, anchor comparisons to the retained best artifact, ask whether subsequent work implemented the proposed change, and bind observations to artifact versions, inputs, budgets and feedback availability. Snapshot existence is explicitly separated from restored execution.
Ownership and behavior boundaries
goals/start_contract.pyowns the shared planning text;work_items/stride_policy.tsowns the existing optional decision-value questions. This adds no Python state-decision owner, strategy registry or second evaluator.docs/reference/protocols/loopx-goal-command-v0.mdand the iterative strategy boundary in the stride RFC, at basef6cf9583794eb8c4cca41fa832a1c2f150059583.Original guidance validation
Source environment: isolated worktree and temporary Effect runtime, Python 3.12.13 / Node 22.23.1.
npm run typecheck:control-plane, Ruff, changed-diff semantic advisory, full semantic vocabulary smoke andgit diff --check: passed.The larger experimental goal remains open: first submission quality versus native under a fixed time/cost protocol, then additional verified gain while a concurrently running native baseline stalls. No merge or benchmark launch is performed by this PR.
Output qualification repair
The original head failed the native base/head CLI differential. The unchanged 96-row public fixture measured +2340 characters for default JSON, +3496 for explicit command-pack detail and +578 for bootstrap Markdown, with no extra lines. The planner, guided transaction and prompt/message entrypoints retain their existing consumers. No instruction or compatibility field was removed for size.
The existing test-only authoring observation now recognizes the complete frozen guidance. Only its absent-to-complete transition on the affected start/bootstrap carriers receives bounded 2400/3600/600 character and byte allowances. Already-present, missing, incomplete, other-surface and over-limit cases still fail; absolute, line, semantic and scale gates stay unchanged. This extends the private probe observation, not a runtime vocabulary, permission or quality classifier.
Repair validation: Python3.12.13 / Node22.22.3; 145 differential/planning tests pass, including clause deletion and one-time/surface/boundary counterexamples. The actual CLI differential passes all 96 unchanged base/head rows against f6cf958, with 11 explicit review signals. Ruff, advisory then full semantic-vocabulary and whitespace checks pass. Original failures remain failures under their old limits. Original guidance validation above is retained evidence, not relabeled as a rerun. Hosted CI and independent review must evaluate this new head.
Related refactor: reuse the existing authoring-input qualification owner; no new framework or parallel product decision. The complete decision text and its diagnostic, cost, acceptance and authority clauses are unchanged by this repair. No frontend behavior, real model, benchmark launch, scoring criterion or merge authority changes. Aggregate experiment consumers still need deliberate adoption of the new source; this push is not their qualification.