fix(backup): complete configuration checkpoints on Windows - #5602
Open
jackie-cqz wants to merge 1 commit into
Open
jackie-cqz wants to merge 1 commit into
jackie-cqz wants to merge 1 commit into
Conversation
Signed-off-by: jackie-cqz <2557911191@qq.com>
jackie-cqz
force-pushed
the
codex/fix-windows-configuration-backup
branch
from
October 4, 2026 17:33
fd9c3b0 to
81bffb6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal And Delivered Outcome
WinError 32while unlinking an open temporary file. Restore preview succeeds, but execution fails withEPERMwhen renaming a staged directory onto a reserved empty directory.mainat37b77d4aff1e1e9faa14487888c055c99482c43e.Author Declaration
docs/reference/configuration-backup.mdat the base revision; the reproduced Windows failures are the repair basis.Scope And Continuation
Complete for configuration-only export and isolated restore. Placement stays in the existing TypeScript IO owner and Python CLI adapter. POSIX keeps the exclusive directory reservation; Windows uses absent-target directory rename. No new capability, vocabulary, configuration switch or activation authority. The bounded refactor review found no useful additional extraction.
Validation
PYTHONUTF8=0), captured output UTF-8. Six configuration-only Python tests and five TS tests pass.configuration-backupbrowser scenario passes against a real disposable Python HTTP backend: download, verification, checkpoint recovery/readback, bad digest and mobile layout.81bffb689c0ae3fd4eb90d21d647db74856c7c62. Windows tests were rerun after the final test-helper encoding adjustment; Linux/browser runs preceded that Windows-only helper adjustment. Runtime and frontend sources are identical.Known separate baseline failures: Windows full
backup-statetests fail atstate_backup.pyread-only-descriptor fsync (EBADF), independently reproduced on unchanged main; this PR does not qualify that workflow. The docs navigation smoke and maintainability ratchet also fail on unchanged main (missing getting-started navigation and the Lark goal-topic module budget). Windows ACL enforcement, provider promotion and destination-machine activation are not certified by these tests.Functional/static test results above preceded the last docs/inventory-only base update; runtime sources, tests and dependency declarations are unchanged. Full semantic validation was rerun on the final rebased revision.
Frontend / Visual Evidence
UI impact: none. The existing Settings → Capability Center backup workflow is exercised with the real backend; no presentation or activation behavior changes.
Boundary Checklist