Fix AttributeError on self.ssl in sha256_password auth branch#148
Open
shychee wants to merge 2 commits into
Open
Fix AttributeError on self.ssl in sha256_password auth branch#148shychee wants to merge 2 commits into
shychee wants to merge 2 commits into
Conversation
Author
|
@long2ice This is a one-line fix — self.ssl was missed in the sha256_password branch and should be self._ssl_context. |
shychee
force-pushed
the
fix/sha256-password-ssl-attribute
branch
from
e4da122 to
425e486
Compare
…sword branch The sha256_password authentication branch in _request_authentication still referenced the old self.ssl instead of self._ssl_context, causing AttributeError when connecting without SSL. Fixes long2ice#147
shychee
force-pushed
the
fix/sha256-password-ssl-attribute
branch
from
425e486 to
1555470
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
self.ssl→self._ssl_contextrename in thesha256_passwordauthentication branch of_request_authenticationsha256_passwordauthentication branch in_request_authenticationstill referenced the oldself.sslinstead ofself._ssl_context, causingAttributeErrorwhen connecting without SSLChange
How to Reproduce
sha256_passwordauth pluginssl=None)AttributeError: 'Connection' object has no attribute 'ssl'Fixes #147