Skip to content

Fix bug with doc field in update - #6

Open
kiryam wants to merge 13 commits into
logstash-plugins:mainfrom
kiryam:master
Open

Fix bug with doc field in update#6
kiryam wants to merge 13 commits into
logstash-plugins:mainfrom
kiryam:master

Conversation

@kiryam

@kiryam kiryam commented Feb 18, 2016

Copy link
Copy Markdown

https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-bulk.html

"Update" should generate event without doc field.

@ghost

ghost commented Feb 18, 2016

Copy link
Copy Markdown

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@kiryam

kiryam commented Mar 5, 2016

Copy link
Copy Markdown
Author

@suyograo can you review it, please?

@untergeek

Copy link
Copy Markdown
Contributor

@kiryam I'm not sure why there are merge conflicts here. Can you please rebase and see what happens? We can't merge it with the branch conflicts.

@kiryam

kiryam commented Mar 29, 2016

Copy link
Copy Markdown
Author

@untergeek done.

@kiryam

kiryam commented Jun 7, 2016

Copy link
Copy Markdown
Author

@untergeek I am sorry, but what about merge?

@karmi

karmi commented Jun 16, 2016

Copy link
Copy Markdown

Hi @kiryam, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@kiryam

kiryam commented Jun 16, 2016

Copy link
Copy Markdown
Author

@karmi I accepted pull request kiryam#1
@sxmichael can you please sign CLA

@sxmichael

Copy link
Copy Markdown

@karmi @kiryam done, signed the CLA

@sxmichael

Copy link
Copy Markdown

@untergeek @karmi hi guys, any update on this?

@loganbhardy

Copy link
Copy Markdown

bump

@untergeek

Copy link
Copy Markdown
Contributor

There are some conflicts in the branch that need to be resolved before we can merge.

@sxmichael

Copy link
Copy Markdown

@kiryam could you please rebase/merge changes from master?

@sxmichael

Copy link
Copy Markdown

i've created new pull request #10 with exactly same changes, in addition of config parameters which control wether to use this functionallity or not.

@shashankbaluni

Copy link
Copy Markdown

Is this fixed, if not any work arounds?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants