ecs: document v8 alias to v1 implementation - #21
Open
yaauie wants to merge 1 commit into
Open
Conversation
kaisecheng
reviewed
Jul 28, 2021
kaisecheng
left a comment
kaisecheng
left a comment
Contributor
There was a problem hiding this comment.
Thanks for updating all v8 related changes. I have a question about the test.
|
|
||
| describe LogStash::Codecs::ESBulk, :ecs_compatibility_support do | ||
| ecs_compatibility_matrix(:disabled, :v1, :v8) do |ecs_select| | ||
| ecs_compatibility_matrix(:disabled, :v1, :v8 => :v1) do |ecs_select| |
Contributor
There was a problem hiding this comment.
here pointed out that we want to test with the setting v8.
I believe both ways can test v8, and the mapping gives handy ecs_select.
Do you think testing with (:disabled, :v1, :v8) is more aligned to the test purpose?
(I think my original test which exclude :disabled is wrong anyway)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.