fix: bump Node to 22 for logseq nightly engines requirement#47
fix: bump Node to 22 for logseq nightly engines requirement#47liby wants to merge 1 commit intologseq:mainfrom
Conversation
logseq@0.0.1 (frontend) now requires node >=22.20.0 in its package.json engines, which breaks publish-spa on Node 20: error logseq@0.0.1: The engine "node" is incompatible with this module. Expected version ">=22.20.0". Got "20.20.2" nbb-logseq 1.2.173 already supports >=20.10.0 so bumping to 22 is safe. Pinned explicitly to '22' instead of 'lts/*' to avoid unintended rolls when the next LTS ships.
|
Hi. This repo doesn't support DB graphs yet and we don't have bandwidth to add that support. I'm closing this because this contribution incorrectly assumes that DB graph support exists by referring to https://github.com/logseq/logseq which is now DB graph only. I've added this note to be more explicit about this repository's current state |
|
Thanks for the response. To clarify the scope of this PR: it does not assume or attempt to add DB graph support — it's a pure Node engine bump. Two reasons it's worth considering independent of DB graph plans:
If the project's stance is that |
Problem
Builds using
version: nightly(and any current logseq frontend commit) fail with:Example failing run: https://github.com/liby/liby/actions/runs/24714459918
Root cause
logseq/logseq
package.jsonnow declaresengines.node": ">=22.20.0", but this action pinsnode-version: '20'inaction.yml(introduced by 394c988 to keep compatibility with then-current nbb-logseq).Why Node 22 is safe now
nbb-logseq 1.2.173 (the version pinned here via
bb: 1.2.174/ related deps) already hasengines.node": ">=20.10.0"in itspackage.json, so moving to 22 does not regress the concern that motivated #46's revert.Why explicit
'22'instead of'lts/*'lts/*auto-rolls when a new Node major becomes LTS, which is exactly what burned #46 last time. Pinning to'22'keeps the upgrade intentional.Change
Single line in
action.yml:node-version: '20'→'22'.