Repository navigation
Bump LUI to ADR 0008 (87fcf6af) and migrate view API - #204
Merged
Merged
Conversation
Idempotent bootstrap: system deps, SDL3 under /opt/sdl3, opam 5.5.0, duniverse + pin-depends, and dune shared cache. Matches the CI gate for shared/native without requiring Xcode or Android SDK. Co-authored-by: Tienson Qin <tiensonqin@gmail.com>
Point opam pin-depends and the Apple Swift package at logseq/lui main 87fcf6af90728bca313b9de991e5bf30564bbc05. Android continues to consume duniverse/lui from this pin; logseq.opam.locked only vendors lui by version, so the SHA lives in pin-depends. Co-authored-by: Tienson Qin <tiensonqin@gmail.com>
Wrap imperative mount closures with custom/mount, replace elem context parent applications, use Menu_anchor for dropdown targets, and add a trailing unit to windowed_keyed so optionals erase under the abstract t type. Co-authored-by: Tienson Qin <tiensonqin@gmail.com>
Use opam env --set-switch so pins and installs target 5.5.0 even when another switch is currently selected. Co-authored-by: Tienson Qin <tiensonqin@gmail.com>
Co-authored-by: Tienson Qin <tiensonqin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump LUI to
87fcf6af90728bca313b9de991e5bf30564bbc05(ADR 0008) and migrate Logseq view code onto the abstract'kind el/custom/mountAPI.Also includes the Cloud Agent Linux install script used to validate the OCaml core gate in this environment.
API migrations (ADR 0008)
t = ui_context -> int option -> int(applyelem context parent)t = general el; mount withLui_elements.mount context ?parent elem(or~parent:node)fun context parent -> …returningtcustom/custom @@ fun context parent -> …(body returns nodeint)custom+mount(seeview_base.mlwith_label*,with_*_prop*)dropdown_menuwithout typed target~target:(Menu_anchor { side; align; offset })(view_settings.ml,view_sidebar.ml)windowed_keyed … ~mountreturning function-typedtunitarg so optionals erase under abstractt(view_rows.mli/ call sites)Touched view modules: authentication, base, composer, flashcards, graphs, outliner, property, query, rows, screens, settings, sidebar.
Validation
dune build @shared/native/all(withLOGSEQ_SQLITE_LINK_FILE/LIBRARY_PATHfor system SQLite on Linux)dune build @shared/native/runtest— 1324 tests OKFollow-ups in this PR
scripts/cloud-agent-install.sh: useopam env --switch=5.5.0 --set-switchso pins/installs hit 5.5.0 when another switch is selected.Notes