Skip to content

Bump LUI to ADR 0008 (87fcf6af) and migrate view API - #204

Merged
tiensonqin merged 5 commits into
mainfrom
logseq/bump-lui-adr-0008-f115
Nov 20, 2026
Merged

tiensonqin merged 5 commits into
mainfrom
logseq/bump-lui-adr-0008-f115

Conversation

@tiensonqin

@tiensonqin tiensonqin commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Bump LUI to 87fcf6af90728bca313b9de991e5bf30564bbc05 (ADR 0008) and migrate Logseq view code onto the abstract 'kind el / custom / mount API.

Also includes the Cloud Agent Linux install script used to validate the OCaml core gate in this environment.

API migrations (ADR 0008)

Before After
t = ui_context -> int option -> int (apply elem context parent) Abstract t = general el; mount with Lui_elements.mount context ?parent elem (or ~parent:node)
Imperative builders as bare fun context parent -> … returning t Wrap with custom / custom @@ fun context parent -> … (body returns node int)
Prop helpers that remount + set properties Same shape via custom + mount (see view_base.ml with_label*, with_*_prop*)
dropdown_menu without typed target ~target:(Menu_anchor { side; align; offset }) (view_settings.ml, view_sidebar.ml)
windowed_keyed … ~mount returning function-typed t Trailing unit arg so optionals erase under abstract t (view_rows.mli / call sites)

Touched view modules: authentication, base, composer, flashcards, graphs, outliner, property, query, rows, screens, settings, sidebar.

Validation

  • dune build @shared/native/all (with LOGSEQ_SQLITE_LINK_FILE / LIBRARY_PATH for system SQLite on Linux)
  • dune build @shared/native/runtest — 1324 tests OK

Follow-ups in this PR

  • scripts/cloud-agent-install.sh: use opam env --switch=5.5.0 --set-switch so pins/installs hit 5.5.0 when another switch is selected.

Notes

  • Apple/Android hosts are unchanged beyond the shared LUI pin; no Swift/Kotlin edits in this PR.
  • Do not merge until CI is green.
Open in Web Open in Cursor 

Devin Review

cursoragent and others added 3 commits November 20, 2026 20:26
Idempotent bootstrap: system deps, SDL3 under /opt/sdl3, opam 5.5.0,
duniverse + pin-depends, and dune shared cache. Matches the CI gate for
shared/native without requiring Xcode or Android SDK.

Co-authored-by: Tienson Qin <tiensonqin@gmail.com>
Point opam pin-depends and the Apple Swift package at logseq/lui main
87fcf6af90728bca313b9de991e5bf30564bbc05. Android continues to consume
duniverse/lui from this pin; logseq.opam.locked only vendors lui by
version, so the SHA lives in pin-depends.

Co-authored-by: Tienson Qin <tiensonqin@gmail.com>
Wrap imperative mount closures with custom/mount, replace
elem context parent applications, use Menu_anchor for dropdown
targets, and add a trailing unit to windowed_keyed so optionals
erase under the abstract t type.

Co-authored-by: Tienson Qin <tiensonqin@gmail.com>
devin-ai-integration[bot]

This comment was marked as resolved.

cursoragent and others added 2 commits November 20, 2026 21:01
Use opam env --set-switch so pins and installs target 5.5.0
even when another switch is currently selected.

Co-authored-by: Tienson Qin <tiensonqin@gmail.com>
Co-authored-by: Tienson Qin <tiensonqin@gmail.com>
@tiensonqin
tiensonqin merged commit be1c8ae into main Nov 20, 2026
5 checks passed
@tiensonqin
tiensonqin deleted the logseq/bump-lui-adr-0008-f115 branch November 20, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants