Repository navigation
Restore Android Compose crash and ANR fix after LUI upgrade - #203
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mobile #194 switched to an LUI revision that omitted the Android layout fix from #185. In Android 2.0.2 (3101), natural-height columns used subcomposition again. That brought back the Compose intrinsic measurement crash and a recomposition loop when recovering from an invalid saved view.
Pin LUI to f13b6f9, which uses a standard Compose column when no child needs to grow and retains constraint-based sizing for weighted children. This also covers the card and panel renderer added in the LUI upgrade.
Sentry reports LOGSEQ-ANDROID-5 and LOGSEQ-ANDROID-6.
Validation