Repository navigation
Upload iOS dSYMs to Sentry and enable safe breadcrumbs - #199
Merged
Merged
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
There was a problem hiding this comment.
Devin Review found 1 finding. Devin automatically fixed it.
Fixed by Devin (1)
- Missing SwiftUI screen breadcrumbs — Screen-name filter now accepts generic type-name punctuation; covered by callback check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes iOS hangs diagnosable in Sentry (LOGSEQ-IOS-9: unsymbolicated in-app frames; LOGSEQ-IOS-8: watchdog termination with 0 breadcrumbs).
dSYMs
DEBUG_INFORMATION_FORMAT=dwarf-with-dsym, checksLogseq.app.dSYMexists, and uploads archive dSYMs withsentry-cli debug-files upload --include-sources --waittologseq/logseq-iosbefore TestFlight.SENTRY_AUTH_TOKENnow fails the release (workflow + Fastfile) instead of silently skipping upload — the silent skip is the likely reason IOS-9 has no symbols. The repo secret must exist before the next release. The OCaml core is statically linked, so its symbols are in the app dSYM.Breadcrumbs (
LogseqCrashReporting.safeBreadcrumb, deny-by-default, max 50)app.lifecyclestate,device.eventLOW_MEMORY,device.connectivity,ui.lifecyclescreen class name,httpmethod/host/status (no path/query),runtimestart/started/drain_begin/drain_end (new manual breadcrumbs inLGRuntime).build_type:debugon IOS-9: no wrong override found (Release config,DEBUGonly in Debug); Sentry derives it from the binary/provisioning profile, so not changed here.Testing
swift build --package-path apple(iOS) passes.sentry-callback-isolationsimulator check extended for the breadcrumb filter: passes.Implemented in session Make iOS hangs diagnosable in Sentry
Review with Devin · Open in Devin Desktop