Skip to content

Upload iOS dSYMs to Sentry and enable safe breadcrumbs - #199

Merged
tiensonqin merged 2 commits into
mainfrom
devin/1795152919-ios-sentry-dsyms-breadcrumbs
Nov 20, 2026
Merged

tiensonqin merged 2 commits into
mainfrom
devin/1795152919-ios-sentry-dsyms-breadcrumbs

Conversation

@tiensonqin

@tiensonqin tiensonqin commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Makes iOS hangs diagnosable in Sentry (LOGSEQ-IOS-9: unsymbolicated in-app frames; LOGSEQ-IOS-8: watchdog termination with 0 breadcrumbs).

dSYMs

  • Release archive forces DEBUG_INFORMATION_FORMAT=dwarf-with-dsym, checks Logseq.app.dSYM exists, and uploads archive dSYMs with sentry-cli debug-files upload --include-sources --wait to logseq/logseq-ios before TestFlight.
  • A missing SENTRY_AUTH_TOKEN now fails the release (workflow + Fastfile) instead of silently skipping upload — the silent skip is the likely reason IOS-9 has no symbols. The repo secret must exist before the next release. The OCaml core is statically linked, so its symbols are in the app dSYM.

Breadcrumbs (LogseqCrashReporting.safeBreadcrumb, deny-by-default, max 50)

  • Kept, rebuilt with only allowlisted fields and no message: app.lifecycle state, device.event LOW_MEMORY, device.connectivity, ui.lifecycle screen class name, http method/host/status (no path/query), runtime start/started/drain_begin/drain_end (new manual breadcrumbs in LGRuntime).
  • Dropped: clicks, console/log, unknown categories, malformed data.

build_type:debug on IOS-9: no wrong override found (Release config, DEBUG only in Debug); Sentry derives it from the binary/provisioning profile, so not changed here.

Testing

  • swift build --package-path apple (iOS) passes.
  • sentry-callback-isolation simulator check extended for the breadcrumb filter: passes.
  • Workflow YAML parses. Real Sentry upload and signed archive not exercised (needs release secrets). Full simulator app build was blocked by unrelated OCaml dependency mismatches.

Mobile Engineer opened this PR for Tienson
Implemented in session Make iOS hangs diagnosable in Sentry
Review with Devin · Open in Devin Desktop


@devin-ai-integration

Copy link
Copy Markdown

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 finding. Devin automatically fixed it.

Fixed by Devin (1)
  • Missing SwiftUI screen breadcrumbs — Screen-name filter now accepts generic type-name punctuation; covered by callback check.

View findings in Devin Review · Follow Devin's work

Devin Review

@tiensonqin
tiensonqin merged commit 0c84870 into main Nov 20, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant