Repository navigation
Implement ADR 0008 typed API ergonomics and safety hardening - #400
Merged
Merged
Conversation
Ship all four ADR phases: capability-indexed Slot_style with compile-time admission, polymorphic 'kind el with uniform reactive/if_/keyed combinators, diff-aware popover/dropdown/split updates, keyed_range performance and scoped rollback, protocol numeric clamping, clean Lui.Ui Tier-1 .mli with dynamic-safe form_section/data_list, and platform-adaptive Tokens spacing. Co-authored-by: Tienson Qin <tiensonqin@gmail.com>
Pass Slot_style.surface_caps through build_dropdown_menu_submenu and build_toolbar_menu so collision-padding and other surface props reach the inner dropdown_menu, matching top-level menu/submenu JSON dispatch. Co-authored-by: Tienson Qin <tiensonqin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements all four phases of ADR 0008 on top of the merged ADR text.
Phase 1 — Safety, PPX façade parity, reactive diffs
Slot_style(make/typography/text_flow/collision) with compile-time admission; removed thestyleexemption fromcomponent_schema_test.mjs.Lui.Elements,Lui.Ui,Lui.Raw, and allSlot_stylebuilders through façade aliases.popover/dropdown_menu/splittarget and sizing updates;textapplies slot style before truncate recipes.Nonewith diagnostics.Phase 2 —
keyed_rangePhase 3 — Polymorphic
'kind elif_/keyed/scoped/dyninside restricted parents.dropdown_menumigrates to?target:dropdown_target;menu/submenu/popovergain capability-checked?style.Phase 4 — Clean
Lui.Uisrc/lui_ui_composites.mliwith noinclude Lui_ui.form_section/data_listtakelist_section_item_el listviaform_row/data_row.form_sheet ~confirm_disabled/~confirm_disabled_signal.Tokens.space_value_for.Migration notes are in
docs/api-migrations.md; ADR status isimplemented.Follow-up
submenu/toolbar_menubuilders now forwardSlot_style.surface_caps(Devin review).Verification
opam exec -- dune build @allopam exec -- dune build @webmake test-ocaml/dune runtest test/(297/297)node --test --test-concurrency=1 tooling/test/{component_schema,ppx-hygiene,menu-item-style,surface-toolbar-style}.test.mjs(25/25)npm --prefix platform/web run check(173/173)