Repository navigation
docs(adr): add ADR 0008 for typed API ergonomics and safety hardening - #399
Merged
Merged
Conversation
Co-authored-by: Tienson Qin <tiensonqin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds ADR 0008 (
docs/adr/0008-typed-api-ergonomics-and-safety-hardening.md), documenting the post-ADR 0007 audit findings and follow-up design for LUI's typed component API before downstream apps standardize on it.Key topics covered
-'caps Slot_style.tto eliminate runtimeInvalid_argumentexceptions on unsupported(kind, property)pairs and remove thestyleexemption intooling/test/component_schema_test.mjs.Lui.Elements/Lui.Ui/Lui.Raw/Lui.Elements.Slot_style.makeresolution inppx/lui_ppx.mlandppx/lui_nesting.ml.apply_popover_target(avoiding redundant 8-keyRemovePropchurn) and single-emitsplitinitialization whensizing_signalis provided.keyed_range.'kind elwith uniformif_/keyed/scoped/reactivecombinators and schema-generatedsrc/lui_elements.mli.include Lui_uifromsrc/lui_ui_composites.ml, addingsrc/lui_ui_composites.mli, fixing static/reactive parameter symmetry (Ui.form_sheet,Ui.form_field), and makingUi.form_section/Ui.data_listdynamic-child safe.Lui.Tokensadoption with platform-adaptive spacing metrics across Web, Apple, Android, and Native.Slot_stylebeforeapply_text_recipeso~truncate:trueis preserved.?styleonmenu/submenu/popoverand migratingdropdown_menutopopover_target.Lui_protocol.normalize_property_valueand unifyingLui_json_viewenum error handling.Testing
docs/adr/0008-typed-api-ergonomics-and-safety-hardening.md).opam exec -- dune build @all @web,make test-schema,make test-ocaml,npm --prefix platform/web run check) prior to branching.