Repository navigation
Keep primary/accent foreground tokens as accent ink - #396
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ADR 0007 Phase 2's slot-aware foreground resolution (#389) mapped
foreground:"primary"toprimary-foregroundon Android, which resolves toscheme.onPrimary. That is white in the light theme, so accent-colored text such as logseq/mobile's Settings section headings became invisible.Only container/surface tokens should map to their
on-*counterpart in a foreground slot.primary/accent tokens used asforegroundnow stay accent ink on every backend. Kotlin, tooling, Web and native tests cover it, anddocs/api-migrations.mdis updated.Implemented in session Implement LUI ADR 0007
Review with Devin · Open in Devin Desktop