Skip to content

Keep primary/accent foreground tokens as accent ink - #396

Merged
tiensonqin merged 3 commits into
mainfrom
devin/1795094515-foreground-accent-ink
Nov 19, 2026
Merged

tiensonqin merged 3 commits into
mainfrom
devin/1795094515-foreground-accent-ink

Conversation

@tiensonqin

@tiensonqin tiensonqin commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

ADR 0007 Phase 2's slot-aware foreground resolution (#389) mapped foreground:"primary" to primary-foreground on Android, which resolves to scheme.onPrimary. That is white in the light theme, so accent-colored text such as logseq/mobile's Settings section headings became invisible.

Only container/surface tokens should map to their on-* counterpart in a foreground slot. primary/accent tokens used as foreground now stay accent ink on every backend. Kotlin, tooling, Web and native tests cover it, and docs/api-migrations.md is updated.


Product Engineer opened this PR for Tienson
Implemented in session Implement LUI ADR 0007
Review with Devin · Open in Devin Desktop


@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

devin-ai-integration[bot]

This comment was marked as resolved.

@tiensonqin
tiensonqin merged commit f27b08a into main Nov 19, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant