ci(template-e2e): install Risc Zero toolchain for the rendered guest build#224
Open
danisharora099 wants to merge 2 commits into
Open
ci(template-e2e): install Risc Zero toolchain for the rendered guest build#224danisharora099 wants to merge 2 commits into
danisharora099 wants to merge 2 commits into
Conversation
…build The `render-and-build` matrix renders a project, builds real lez/spel via `setup`, asserts `doctor` is clean, then runs `lgs build` on the rendered workspace. That last step cross-compiles the template's risc0 guest crate (methods/) to riscv32im-risc0-zkvm-elf, which needs the Risc Zero Rust toolchain — but the workflow never installed it, so every run panicked with "Risc Zero Rust toolchain not found. Try running `rzup install rust`". Add an rzup step before the build to register the `risc0` toolchain that risc0-build discovers. Everything earlier in the job (render, setup, the full LEZ/spel build, circuits fetch, doctor) was already passing; this closes the only failing step.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the Template E2E workflow’s render-and-build job by installing the Risc Zero Rust toolchain needed to compile the rendered template’s risc0 guest crate during the final workspace build.
Changes:
- Add an
rzupinstallation step to install/register therisc0rustup toolchain before building the rendered project. - Document why the toolchain is required (risc0 guest cross-compilation).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Review nits: use `curl -fsSL` so an HTTP error page fails the step instead of being piped into bash (matches the existing `curl -fL` circuits fetch), and refer to the `logos-scaffold build` step by the command the workflow actually runs rather than the `lgs` alias.
Contributor
Author
|
Addressed both review nits in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Template E2E workflow's
render-and-buildmatrix (default+lez-framework) has been failing on every run, across unrelated PRs and dates — e.g. #221's first run and #210 (wozos/scaffold-deslop) going back to early June. It is not a required check, so it hasn't blocked merges, but it leaves a persistent red ✗ on any PR that touchessrc/constants.rs,templates/**, orsrc/template/**.Root cause
The job's final step renders a project, builds real lez/spel via
setup, assertsdoctoris clean, then runslgs buildon the rendered workspace. That last step cross-compiles the template's risc0 guest crate (methods/) toriscv32im-risc0-zkvm-elf, which needs the Risc Zero Rust toolchain. The workflow never installed it, so the guest build script panics:Everything earlier in the job (render →
setup's full LEZ/spel build → circuits fetch →doctorzero-FAIL) already passes; this is the only failing step.Fix
Add an
rzupstep before the build to install and register therisc0rustup toolchain thatrisc0-builddiscovers. One added step, no other behavior change.Notes
render-and-buildjobs go green.