feat(twap-oracle): implement CreateCurrentTickAccount and UpdateCurre…#131
Open
0x-r4bbit wants to merge 1 commit into
Open
feat(twap-oracle): implement CreateCurrentTickAccount and UpdateCurre…#1310x-r4bbit wants to merge 1 commit into
0x-r4bbit wants to merge 1 commit into
Conversation
Collaborator
Author
|
Needs #130 to land first. |
Collaborator
Author
|
Closing and reopening to trigger CI checks. |
0x-r4bbit
force-pushed
the
feat/tick_account
branch
from
6426a50 to
ab6f4e7
Compare
There was a problem hiding this comment.
Pull request overview
This PR expands the TWAP oracle program from a placeholder/no-op into a set of concrete initialization + update primitives for oracle-owned PDAs. It introduces (1) per-(price source, window) observation accounts, (2) per-(price source, window) canonical oracle price accounts, and (3) a per–price-source “current tick” PDA that the price source updates after price-changing operations.
Changes:
- Add
CreatePriceObservations,CreateOraclePriceAccount,CreateCurrentTickAccount, andUpdateCurrentTickinstructions + guest entrypoints. - Implement PDA derivation helpers and new account types (
PriceObservations,CurrentTickAccount) intwap_oracle_core(and updateOraclePriceAccount.source_idtoAccountId). - Update IDL artifacts and Cargo dependencies/lockfiles to include new crates (e.g.,
clock_core,risc0-zkvmin core).
Reviewed changes
Copilot reviewed 13 out of 19 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| programs/twap_oracle/src/update_current_tick.rs | Implements updating an existing CurrentTickAccount and adds unit tests. |
| programs/twap_oracle/src/noop.rs | Removes the previous no-op implementation. |
| programs/twap_oracle/src/lib.rs | Exposes new instruction modules from the program crate. |
| programs/twap_oracle/src/create_price_observations.rs | Adds initialization for PriceObservations PDA (per source+window) and tests. |
| programs/twap_oracle/src/create_oracle_price_account.rs | Adds initialization for OraclePriceAccount PDA (per source+window) and tests. |
| programs/twap_oracle/src/create_current_tick_account.rs | Adds initialization for CurrentTickAccount PDA (per source) and tests. |
| programs/twap_oracle/methods/guest/src/bin/twap_oracle.rs | Replaces no-op guest entrypoint with guest instruction wrappers for the new APIs. |
| programs/twap_oracle/methods/guest/Cargo.toml | Adds clock_core dependency needed by new guest code. |
| programs/twap_oracle/methods/guest/Cargo.lock | Lockfile updates for new guest dependencies. |
| programs/twap_oracle/core/src/lib.rs | Adds new instructions, PDA seed helpers, and new account types in core. |
| programs/twap_oracle/core/Cargo.toml | Enables workspace lints and adds risc0-zkvm dependency needed for hashing PDA seeds. |
| programs/twap_oracle/Cargo.toml | Adds clock_core dependency and enables workspace lints. |
| programs/token/methods/guest/Cargo.lock | Workspace lockfile churn from dependency updates. |
| programs/stablecoin/methods/guest/Cargo.lock | Workspace lockfile churn from dependency updates. |
| programs/ata/methods/guest/Cargo.lock | Workspace lockfile churn from dependency updates. |
| programs/amm/methods/guest/Cargo.lock | Workspace lockfile churn from dependency updates. |
| Cargo.lock | Workspace lockfile churn from dependency updates. |
| artifacts/twap_oracle-idl.json | Updates the oracle IDL to reflect new instructions and account/types. |
| artifacts/stablecoin-idl.json | Updates generated IDL types (reflecting updated shared types). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| price_source_id: AccountId, | ||
| window_duration: u64, | ||
| ) -> PdaSeed { | ||
| use risc0_zkvm::sha::{Impl, Sha256}; |
| price_source_id: AccountId, | ||
| window_duration: u64, | ||
| ) -> PdaSeed { | ||
| use risc0_zkvm::sha::{Impl, Sha256}; |
| /// Hash input: `price_source_id (32 bytes) || CURRENT_TICK_ACCOUNT_PDA_SEED (32 bytes)`. | ||
| #[must_use] | ||
| pub fn compute_current_tick_account_pda_seed(price_source_id: AccountId) -> PdaSeed { | ||
| use risc0_zkvm::sha::{Impl, Sha256}; |
Comment on lines
+65
to
+68
| mod tests { | ||
| use nssa_core::account::{AccountId, Nonce}; | ||
|
|
||
| use super::*; |
Comment on lines
+84
to
+87
| mod tests { | ||
| use nssa_core::account::{AccountId, Nonce}; | ||
|
|
||
| use super::*; |
Comment on lines
+75
to
+79
| mod tests { | ||
| use nssa_core::account::Nonce; | ||
|
|
||
| use super::*; | ||
|
|
Comment on lines
+52
to
+56
| mod tests { | ||
| use nssa_core::account::{Account, AccountId, Nonce}; | ||
| use twap_oracle_core::compute_current_tick_account_pda; | ||
|
|
||
| use super::*; |
…ntTick Add CurrentTickAccount — an oracle-owned PDA (one per price source) that holds the latest raw tick written by the price source and a timestamp. The price source calls UpdateCurrentTick after each price-changing operation; anyone can then call RecordTick (upcoming) to advance the PriceObservations accumulator without requiring the price source to be present. PDA is derived from price_source_id only (no window) since a single current tick serves all time windows. Add price_to_tick(price: u128) -> i32 to twap_oracle_core: isqrt(price << 128) -> sqrtPriceX96 -> get_tick_at_sqrt_ratio. The sqrtPriceX96 is clamped to >= MIN_SQRT_RATIO so a zero/dust price maps to MIN_TICK rather than erroring. Add a pure-integer integer_sqrt(U256) (bit-by-bit, no floating point): ruint's root is gated behind its std feature and seeds with f64, neither available in the guest. Uses wrapping_shr for the digit loop (checked_shr rejects the intended lossy shifts). Pull in uniswap_v3_math (for get_tick_at_sqrt_ratio) and alloy-primitives (U256), with ruint pinned to =1.17.0 — 1.18 raised its MSRV to rustc 1.90, above the risc0 guest toolchain's 1.88.
0x-r4bbit
force-pushed
the
feat/tick_account
branch
from
ab6f4e7 to
a314501
Compare
Collaborator
Author
|
Updated this to take in prices as Q64.64 instead of ticks. So #139 will not be needed anymore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ntTick
Add CurrentTickAccount — an oracle-owned PDA (one per price source) that holds the latest raw tick written by the price source and a timestamp. The price source calls UpdateCurrentTick after each price-changing operation; anyone can then call RecordTick (upcoming) to advance the PriceObservations accumulator without requiring the price source to be present. PDA is derived from price_source_id only (no window) since a single current tick serves all time windows.