Skip to content

Change MojoFailureException text to explain what file are not minifie… - #7

Open
ainGitHub wants to merge 1 commit into
logicsquad:developfrom
ainGitHub:issues-6
Open

Change MojoFailureException text to explain what file are not minifie…#7
ainGitHub wants to merge 1 commit into
logicsquad:developfrom
ainGitHub:issues-6

Conversation

@ainGitHub

Copy link
Copy Markdown

…d. Change code to more java code stile like

@ainGitHub

Copy link
Copy Markdown
Author

Original code style and formattings, not equal default Intellij Idea Java formatting, and idea automatically formatting all file. Real changes in file not more

@paulhoadley

Copy link
Copy Markdown
Contributor

idea automatically formatting all file.

Yes it sure did!

Thanks for your contribution—I appreciate your input. But I can't use this commit as-is: it changes every line of the file. Eyeballing it, I see the following:

  • Changes signature of minify() to take Function<Reader, ? extends Minifier> minifierCreate—I quite like that, nicer than the Class argument that then requires reflection.
  • Change to MojoFailureException message at your line 150. Again, nice change.

I am happy to just transcribe those changes over to the develop branch and credit you in the commit comment, or you're welcome to delete 8786e45 and submit a new commit that changes only those lines.

Thanks again!

@paulhoadley
paulhoadley self-requested a review April 26, 2025 06:40
@paulhoadley paulhoadley self-assigned this Apr 26, 2025
@paulhoadley paulhoadley added the enhancement New feature or request label Apr 26, 2025
@paulhoadley paulhoadley added this to the 1.3 milestone Apr 26, 2025
@ainGitHub

ainGitHub commented Apr 28, 2025

Copy link
Copy Markdown
Author

idea automatically formatting all file.

Yes it sure did!

Thanks for your contribution—I appreciate your input. But I can't use this commit as-is: it changes every line of the file. Eyeballing it, I see the following:

  • Changes signature of minify() to take Function<Reader, ? extends Minifier> minifierCreate—I quite like that, nicer than the Class argument that then requires reflection.
  • Change to MojoFailureException message at your line 150. Again, nice change.

I am happy to just transcribe those changes over to the develop branch and credit you in the commit comment, or you're welcome to delete 8786e45 and submit a new commit that changes only those lines.

Thanks again!

Sure, let's do it your way. This is how my Idea formats the code and therefore shows that all lines are changed. Thanks

@ainGitHub

ainGitHub commented May 12, 2025

Copy link
Copy Markdown
Author

@paulhoadley , please check code, I change styling, that show only changed rows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants