Open
Conversation
…dNote) Design doc for replacing the monolithic localSearch tool with three focused tools: vaultFind (metadata), vaultSearch (content), readNote (unchanged). Motivated by bug #2267 where timeRange was silently dropped in the Miyo code path due to tangled metadata/content filtering responsibilities. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add example 11: "Summarize the budget discussions in my meeting notes from last week under Q3Meetings" — combines time + folder + content search, the most complex composition pattern. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Design decisions resolved: - Remove salientTerms from agent-facing schema (tool extracts internally) - Remove sortBy, limit, headings from vaultFind (hardcode mtime, 200, none) - Remove returnAll from vaultSearch schema - Remove paths cap (no limit — paths are cheap strings) - Miyo MUST support path-scoped search (not optional post-filter) - Semantic search deprecated — only lexical + Miyo backends - Add fallback guidance in agent instructions (0 results case) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the monolithic
localSearchtool with three focused tools that mirror Unixfind/grep/cat:vaultFindfindvaultSearchgrepreadNotecatMotivation
The current
localSearchhandles time filtering, tag matching, title matching, AND content search in one tool. This caused #2267 wheretimeRangewas silently dropped in the Miyo code path. More fundamentally, the monolithic design prevents the agent from composing multi-step queries intelligently.Key Design Decisions
vaultFindis always local — uses Obsidian's vault API and metadataCache. No Miyo, no embeddings, no Node.js dependency (mobile-safe).vaultSearchhas NO metadata filtering — pure content search. Time/tag/folder filtering isvaultFind's job.pathsparameter —vaultSearchaccepts optionalpathsfrom avaultFindresult to scope content search to specific files.vaultFindreturns headings (free from cache), giving the agent enough context to decide what to read without blowing up context.Query Examples
Design Doc
Full design doc with schemas, 10 query examples, agent instructions, migration plan, and implementation notes:
designdocs/VAULT_SEARCH_REDESIGN.md