feat: migrate API keys to Obsidian SecretStorage (keychain)#2200
Draft
logancyang wants to merge 1 commit intomasterfrom
Draft
feat: migrate API keys to Obsidian SecretStorage (keychain)#2200logancyang wants to merge 1 commit intomasterfrom
logancyang wants to merge 1 commit intomasterfrom
Conversation
Design doc for migrating all API keys and tokens from data.json to Obsidian's native SecretStorage (keychain) API. Covers the upgrade path for existing users, legacy encryption deprecation, and MarkdownRenderer breaking change from the API version bump. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/KEYCHAIN_MIGRATION.md) for migrating all API keys and tokens fromdata.jsonto Obsidian's native SecretStorage API (OS keychain)data.jsonfields cleared, one-time notice shownencryptionService.ts(hardcoded Web Crypto key + cross-platform failures)Key decisions
enc_values, write to keychain, cleardata.json. Idempotent.getDecryptedKey(async) replaced bykeychain.getProviderKey()(sync)Test plan
🤖 Generated with Claude Code