feat: add support for Github Copilot as a provider#1564
feat: add support for Github Copilot as a provider#1564caezium wants to merge 5 commits intologancyang:masterfrom
Conversation
|
bugbot run |
…rrors, token calculation (rn approximation)
|
bugbot run :( |
|
bugbot run |
|
should be fixed |
|
bugbot run |
There was a problem hiding this comment.
Bug: Refactoring Breaks Provider Validation
The createModelInstance method was refactored, introducing a call to the undefined this.getProviderConstructor(model), which causes a runtime error for all non-GitHub Copilot providers. This refactoring also removed critical validation checks for model existence and API key presence, leading to less informative errors or failures when API keys are missing for these providers.
src/LLMProviders/chatModelManager.ts#L363-L378
obsidian-copilot/src/LLMProviders/chatModelManager.ts
Lines 363 to 378 in ba51103
Bug: Constructor Ignores Config, Provider Uninitialized
The ChatGitHubCopilot class's constructor ignores its config parameter, creating an unconfigured GitHubCopilotProvider. This suggests the class is either unused or incorrectly implemented.
src/LLMProviders/githubCopilotChatModel.ts#L84-L108
obsidian-copilot/src/LLMProviders/githubCopilotChatModel.ts
Lines 84 to 108 in ba51103
Was this report helpful? Give feedback by reacting with 👍 or 👎
|
omg mb |
|
fixed. i tested the other models too. do i have to provide api keys for the integration test that keeps failing? |
|
Can't wait for this to get merged |
|
sorry, i will review the code later |
|
ok ty, sorry if my code isn't perfect |
|
I've been really looking forward to this feature. What's the current status? |
You can now authenticate with Github to use Github Copilot as a model provider.
#506
does not support streaming as it already bypasses CORS
does not support auto-getting available models