Repository navigation
Fix object ID of the Microsoft Entra ID Admin group - #33
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The placeholders prevent use of a tenant-specific group and align with the documented requirement to configure variables before execution.
Review effort: Balanced
Findings: None
What changed in this PR
Replaces tenant-specific Microsoft Entra admin group IDs with configurable placeholders.
Changes:
- Added explanatory comments for the admin group object ID.
- Replaced hard-coded IDs in both AKS provisioning variants.
| File | Description |
|---|---|
scripts/01-user-assigned-managed-identity.sh |
Uses an admin group ID placeholder. |
scripts/01-system-assigned-managed-identity.sh |
Uses an admin group ID placeholder. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR changes the object ID of the Microsoft Entra ID Admin group.
Changes
aad_profile_admin_group_object_idsvariable in the./scripts/01-user-assigned-managed-identity.shscript.aad_profile_admin_group_object_idsvariable in the./scripts/01-system-assigned-managed-identity.shscript.