Skip to content

SYN-592: Remediate critical dependency findings - #7

Open
KARSE22 wants to merge 2 commits into
masterfrom
chore/SYN-592/remediate-critical-dependencies
Open

SYN-592: Remediate critical dependency findings#7
KARSE22 wants to merge 2 commits into
masterfrom
chore/SYN-592/remediate-critical-dependencies

Conversation

@KARSE22

@KARSE22 KARSE22 commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Resolves the critical npm dependency findings tracked in SYN-592. The change is limited to package metadata and does not modify application code.

What changed

  • Upgraded webpack, @babel/traverse, minimist, and form-data to patched versions.
  • Declared terser-webpack-plugin directly because the existing webpack configuration imports it.
  • Regenerated the lockfile and synchronized the package version metadata.

Validation

Ran a clean install, all 29 tests, lint, and the production build. A fresh audit reports 0 critical findings. I also loaded both CDN bundles in Chromium and confirmed they initialize without console errors.

Compatibility

The updated dependency graph requires Node 18 or newer through node-releases. The repository does not currently declare a supported Node version, and validation passed on Node 20, 22, and 24.

Pin the affected transitive dependency paths to safe versions and declare terser-webpack-plugin directly for the existing webpack config.
@guardrails

guardrails Bot commented Aug 19, 2026

Copy link
Copy Markdown

⚠️ We detected 6 security issues in this pull request:

Vulnerable Libraries (6)
Severity Details
Critical pkg:npm/eslint@4.19.1 (t) upgrade to: 9.26.0
High pkg:npm/@babel/core@7.14.6 (t) upgrade to: > 7.14.6
High pkg:npm/webpack-cli@4.7.2 (t) upgrade to: > 4.7.2
Medium pkg:npm/@babel/register@7.14.5 (t) upgrade to: > 7.14.5
High pkg:npm/mocha@9.0.2 (t) upgrade to: > 9.0.2
Medium pkg:npm/@babel/preset-env@7.14.7 (t) upgrade to: > 7.14.7

More info on how to fix Vulnerable Libraries in JavaScript.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@KARSE22
KARSE22 marked this pull request as ready for review August 19, 2026 01:51

@samkitsheth95 samkitsheth95 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we should test it out once released.

Comment thread package.json Outdated
Comment on lines +13 to +26
"@babel/traverse": "^7.29.8",
"chai": "^4.3.4",
"chai-spies": "^1.0.0",
"eslint": "^4.14.0",
"express": "^4.17.1",
"form-data": "^3.0.5",
"jquery": "^3.6.0",
"jquery-ui": "^1.12.1",
"jsdom": "^16.6.0",
"minimist": "^1.2.8",
"mocha": "^9.0.0",
"sinon": "^11.1.1",
"webpack": "^5.37.0",
"terser-webpack-plugin": "^5.6.1",
"webpack": "^5.109.2",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the new packages being added without any code references?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, good callout. Those are transitive dependencies tied to the audit findings, and I initially thought adding direct pins was the safest way to force the patched versions. But you're right, they don't belong in package.json since the code doesn't use them directly. I removed the direct entries and kept the patched versions in package-lock.json. The only new direct dependency is terser-webpack-plugin, which webpack.config.js imports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants