Conversation
It turns out that removing the SIGKILL from lightningd/subd.c can cause CLN to deadlock on shutdown, which holds up coverage reporting. Add the SIGKILL back in, but first attempt to gracefully shutdown by closing the subdaemon socket and waiting 5s for it. The socket close handles most of the deadlock cases while preserving coverage data. The fallback SIGKILL causes some coverage data to be lost but prevents coverage runs from deadlocking forever.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that removing the
SIGKILLfromlightningd/subd.ccan cause CLN to deadlock on shutdown, which holds up coverage reporting. Add theSIGKILLback in, but first attempt to gracefully shutdown by closing the subdaemon socket and waiting 5s for it. The socket close handles most of the deadlock cases while preserving coverage data. The fallbackSIGKILLcauses some coverage data to be lost but prevents coverage runs from deadlocking forever.