Skip to content

smite-scenarios: build invalid programs using raw_program - #254

Open
morehouse wants to merge 1 commit into
masterfrom
executor_test_raw_program
Open

morehouse wants to merge 1 commit into
masterfrom
executor_test_raw_program

Conversation

@morehouse

Copy link
Copy Markdown
Collaborator

Add a raw_program helper to build programs that are malformed and therefore can't use ProgramBuilder (which would panic).

Add a raw_program() helper to build programs that are malformed and
therefore can't use ProgramBuilder (which would panic).

@erickcestari erickcestari left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines 1 to 5
//! Program fragments used by executor tests.
//!
//! Each helper appends one fragment to a [`ProgramBuilder`] and returns the
//! variables it produced, so that callers compose fragments without tracking
//! instruction indices. `*_program` helpers build a whole program.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The module doc is not true anymore, since raw_program doesn't append to a ProgramBuilder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants