smite: add funding_signed oracle - #212
Open
NishantBansal2003 wants to merge 1 commit into
Open
NishantBansal2003 wants to merge 1 commit into
NishantBansal2003 wants to merge 1 commit into
Conversation
NishantBansal2003
force-pushed
the
funding-signed-oracle
branch
2 times, most recently
from
August 31, 2026 06:54
bd3f330 to
f491ce2
Compare
morehouse
reviewed
Sep 15, 2026
| } | ||
|
|
||
| #[test] | ||
| fn execute_recv_channel_ready_invalid_signature_is_noop() { |
Collaborator
There was a problem hiding this comment.
Also needs a test that RecvFundingSigned reports a violation when the funding_created signature is invalid.
Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
NishantBansal2003
force-pushed
the
funding-signed-oracle
branch
from
September 15, 2026 19:47
f491ce2 to
9696b9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
FundingSignedOracleand consolidate all the previously scattered checks relevant to the funding flow negotiation into it, including unknownchannel_id, cases where the target accepted an invalidfunding_createdwe sent, and cases where the target sent an invalidfunding_signed.