Draft
Conversation
…nality, replacing the previous axios-based implementation.
Key Changes
1. GraphQL Mutations Added
- newUserEmailRegistrationInitiate - Initiates email registration by sending a code
- newUserEmailRegistrationValidate - Validates the email code and returns auth token
2. Email Login Screens Refactored
- email-login-initiate.tsx:
- Migrated from axios to GraphQL mutation
- Added Firebase Crashlytics error tracking
- Removed useAppConfig dependency for auth URL
- Improved error handling for rate limiting
- email-login-validate.tsx:
- Migrated from axios to GraphQL mutation
- Added Crashlytics error tracking
- Handles TOTP flow if 2FA is enabled
- Better error messages for invalid codes and rate limiting
3. Code Quality Improvements
- Removed unused useEffect import
- Fixed parameter naming consistency (emailFlowId throughout)
- Removed commented localhost URL from codegen.yml
- Uses existing translation keys from LL.errors instead of creating new ones
4. Technical Details
- Generated GraphQL types for type safety
- Proper error handling with specific error codes (TOO_MANY_REQUEST, INVALID_CODE)
- Analytics tracking for successful email login
- Navigation flow: Initiate → Validate → (TOTP if required) → Home
Files Modified
- app/screens/email-login-screen/email-login-initiate.tsx
- app/screens/email-login-screen/email-login-validate.tsx
- app/navigation/stack-param-lists.ts
- codegen.yml
- app/graphql/generated.gql (auto-generated)
- app/graphql/generated.ts (auto-generated)
Nodirbek75
requested changes
Sep 17, 2025
Contributor
|
Need to update the Email card description: 
|
islandbitcoin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes
Files Modified