fix: close race windows in charge creation and webhook processing - #16
Merged
Conversation
Wrap charge+idempotency-key writes and webhook markAsProcessed+charge transition in a single DB transaction via a new TransactionRunner, with pessimistic row locking on the charge read during webhook processing. Previously these were separate writes: a crash between them could create a duplicate charge, and concurrent webhooks could lose one side's state transition. Concurrent idempotency-key inserts now resolve gracefully via the unique constraint instead of surfacing a 500. Also sets explicit DB pool/timeout limits instead of relying on driver defaults. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap charge+idempotency-key writes and webhook markAsProcessed+charge transition in a single DB transaction via a new TransactionRunner, with pessimistic row locking on the charge read during webhook processing. Previously these were separate writes: a crash between them could create a duplicate charge, and concurrent webhooks could lose one side's state transition. Concurrent idempotency-key inserts now resolve gracefully via the unique constraint instead of surfacing a 500. Also sets explicit DB pool/timeout limits instead of relying on driver defaults.