chore: finalize MVP — health probe, structured logging, and CI - #13
Merged
Conversation
tsconfig.build.json was including the root-level vitest.config.ts, causing TypeScript to infer rootDir as '.' instead of 'src'. This nested all compiled output under dist/src/ instead of dist/, so the container could not find dist/main at startup.
Without a max constraint, values above PostgreSQL's integer limit (2,147,483,647) passed Zod validation but crashed at the DB layer with a 500. Now returns 400 at the validation boundary.
fix: resolve Docker startup crash and amount overflow 500
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR
Closes the MVP scope with the last four shippable pieces:
GET /health— liveness probe returning{ "status": "ok" }, wired into Docker Composehealthchecksoapponly starts afterdbis healthyAsyncLocalStorage(no NestJS request scope required)codefield (CHARGE_NOT_FOUND,IDEMPOTENCY_CONFLICT, etc.)Test plan
npm test)docker compose up --buildstarts cleanly with both services healthy